Promote warning to exception in constant() function

Author: kocsismate

ext/standard/basic_functions.c

@@ -2040,7 +2040,7 @@ PHP_FUNCTION(constant)
 		}
 	} else {
 		if (!EG(exception)) {
-			php_error_docref(NULL, E_WARNING, "Couldn't find constant %s", ZSTR_VAL(const_name));
+			zend_value_error("Couldn't find constant %s", ZSTR_VAL(const_name));
 		}
 		RETURN_NULL();
 	}
@@ -3202,7 +3202,7 @@ static int user_shutdown_function_call(zval *zv) /* {{{ */
 	if (!zend_is_callable(&shutdown_function_entry->arguments[0], 0, NULL)) {
 		zend_string *function_name
 			= zend_get_callable_name(&shutdown_function_entry->arguments[0]);
-		php_error(E_WARNING, "(Registered shutdown functions) Unable to call %s() - function does not exist", ZSTR_VAL(function_name));
+		zend_value_error("(Registered shutdown functions) Unable to call %s() - function does not exist", ZSTR_VAL(function_name));
 		zend_string_release_ex(function_name, 0);
 		return 0;
 	}
@@ -3240,15 +3240,15 @@ static void user_tick_function_call(user_tick_function_entry *tick_fe) /* {{{ */
 			zval *obj, *method;
 
 			if (Z_TYPE_P(function) == IS_STRING) {
-				php_error_docref(NULL, E_WARNING, "Unable to call %s() - function does not exist", Z_STRVAL_P(function));
+				zend_value_error("Unable to call %s() - function does not exist", Z_STRVAL_P(function));
 			} else if (	Z_TYPE_P(function) == IS_ARRAY
 						&& (obj = zend_hash_index_find(Z_ARRVAL_P(function), 0)) != NULL
 						&& (method = zend_hash_index_find(Z_ARRVAL_P(function), 1)) != NULL
 						&& Z_TYPE_P(obj) == IS_OBJECT
 						&& Z_TYPE_P(method) == IS_STRING) {
-				php_error_docref(NULL, E_WARNING, "Unable to call %s::%s() - function does not exist", ZSTR_VAL(Z_OBJCE_P(obj)->name), Z_STRVAL_P(method));
+				zend_value_error("Unable to call %s::%s() - function does not exist", ZSTR_VAL(Z_OBJCE_P(obj)->name), Z_STRVAL_P(method));
 			} else {
-				php_error_docref(NULL, E_WARNING, "Unable to call tick function");
+				zend_value_error("Unable to call tick function");
 			}
 		}
 

ext/standard/tests/general_functions/bug72920.phpt

@@ -6,7 +6,10 @@ class Foo {
 	private const C1 = "a";
 }
 
-var_dump(constant('Foo::C1'));
+try {
+    constant('Foo::C1');
+} catch (ValueError $exception) {
+    echo $exception->getMessage() . "\n";
+}
 --EXPECTF--
-Warning: constant(): Couldn't find constant Foo::C1 in %s on line %d
-NULL
+Couldn't find constant Foo::C1