Remove always-true check in pdo_stmt.c (#17535)

nielsdos · web-flow · commit c218f629202c · 2025-01-21T19:20:57.000+01:00
`check_empty` is checked earlier up, so this variable is always true.
diff --git a/ext/pdo/pdo_stmt.c b/ext/pdo/pdo_stmt.c
@@ -2360,7 +2360,7 @@ static int row_dim_exists(zend_object *object, zval *offset, int check_empty)
 			return false;
 		}
 		ZEND_ASSERT(retval == &tmp_val);
-		bool res = check_empty ? i_zend_is_true(retval) : Z_TYPE(tmp_val) != IS_NULL;
+		bool res = i_zend_is_true(retval);
 		zval_ptr_dtor_nogc(retval);
 		return res;
 	} else {

Original file line number	Diff line number	Diff line change
`@@ -2360,7 +2360,7 @@ static int row_dim_exists(zend_object object, zval offset, int check_empty)`
`2360`	`2360`	`return false;`
`2361`	`2361`	`}`
`2362`	`2362`	`ZEND_ASSERT(retval == &tmp_val);`
`2363`		`- bool res = check_empty ? i_zend_is_true(retval) : Z_TYPE(tmp_val) != IS_NULL;`
	`2363`	`+ bool res = i_zend_is_true(retval);`
`2364`	`2364`	`zval_ptr_dtor_nogc(retval);`
`2365`	`2365`	`return res;`
`2366`	`2366`	`} else {`