Use assertion for user filters

Girgias · Girgias · commit c0aea243c1c9 · 2020-09-02T17:39:06.000+02:00
diff --git a/ext/standard/user_filters.c b/ext/standard/user_filters.c
@@ -299,12 +299,7 @@ static php_stream_filter *user_filter_factory_create(const char *filtername,
 			}
 			efree(wildcard);
 		}
-		if (fdat == NULL) {
-			zend_throw_error(NULL, "Filter \"%s\" is not in the user-filter map, "
-				"but user-filter-factory was invoked for it."
-				"This is a bug, please report it at https://bugs.php.net", filtername);
-			return NULL;
-		}
+		ZEND_ASSERT(fdat);
 	}
 
 	/* bind the classname to the actual class */

Original file line number	Diff line number	Diff line change
`@@ -299,12 +299,7 @@ static php_stream_filter user_filter_factory_create(const char filtername,`
`299`	`299`	`}`
`300`	`300`	`efree(wildcard);`
`301`	`301`	`}`
`302`		`- if (fdat == NULL) {`
`303`		`- zend_throw_error(NULL, "Filter \"%s\" is not in the user-filter map, "`
`304`		`- "but user-filter-factory was invoked for it."`
`305`		`- "This is a bug, please report it at https://bugs.php.net", filtername);`
`306`		`- return NULL;`
`307`		`- }`
	`302`	`+ ZEND_ASSERT(fdat);`
`308`	`303`	`}`
`309`	`304`
`310`	`305`	`/* bind the classname to the actual class */`