Use zend_string_equals() API instead of strcmp() in COM extension

Girgias · Girgias · commit bd918b1ffbdb · 2021-03-17T11:57:57.000Z
diff --git a/ext/com_dotnet/php_com_dotnet_internal.h b/ext/com_dotnet/php_com_dotnet_internal.h
@@ -51,9 +51,9 @@ typedef struct _php_com_dotnet_object {
 static inline int php_com_is_valid_object(zval *zv)
 {
 	zend_class_entry *ce = Z_OBJCE_P(zv);
-	return strcmp("com", ce->name->val) == 0 ||
-		strcmp("dotnet", ce->name->val) == 0 ||
-		strcmp("variant", ce->name->val) == 0;
+	return zend_string_equals_literal(ce->name, "com") ||
+		zend_string_equals_literal(ce->name, "dotnet") ||
+		zend_string_equals_literal(ce->name, "variant");
 }
 
 #define CDNO_FETCH(zv)			(php_com_dotnet_object*)Z_OBJ_P(zv)

Original file line number	Diff line number	Diff line change
`@@ -51,9 +51,9 @@ typedef struct _php_com_dotnet_object {`
`51`	`51`	`static inline int php_com_is_valid_object(zval *zv)`
`52`	`52`	`{`
`53`	`53`	`zend_class_entry *ce = Z_OBJCE_P(zv);`
`54`		`- return strcmp("com", ce->name->val) == 0 \|\|`
`55`		`- strcmp("dotnet", ce->name->val) == 0 \|\|`
`56`		`- strcmp("variant", ce->name->val) == 0;`
	`54`	`+ return zend_string_equals_literal(ce->name, "com") \|\|`
	`55`	`+ zend_string_equals_literal(ce->name, "dotnet") \|\|`
	`56`	`+ zend_string_equals_literal(ce->name, "variant");`
`57`	`57`	`}`
`58`	`58`
`59`	`59`	`#define CDNO_FETCH(zv) (php_com_dotnet_object*)Z_OBJ_P(zv)`