Fix string offset access

Author: Girgias

Zend/tests/float_to_int/warning_float_does_not_fit_zend_long_strings.phpt

@@ -70,14 +70,10 @@ Warning: String offset cast occurred in %s on line %d
 string(1) "H"
 Float casted to string compile
 
-Deprecated: Implicit conversion to int from non-compatible float-string in %s on line %d
-
 Warning: Uninitialized string offset 9223372036854775807 in %s on line %d
 TypeError
 Float string variable
 
-Deprecated: Implicit conversion to int from non-compatible float-string in %s on line %d
-
 Warning: Uninitialized string offset 9223372036854775807 in %s on line %d
 TypeError
 Attempt to assign

Zend/zend_execute.c

@@ -1438,7 +1438,7 @@ static zend_never_inline zend_long zend_check_string_offset(zval *dim, int type
 				break;
 		}
 
-		offset = zval_get_long_func(dim, true);
+		offset = zval_get_long_func(dim, /* lax */ true);
 	} else {
 		offset = Z_LVAL_P(dim);
 	}
@@ -2374,7 +2374,6 @@ static zend_always_inline void zend_fetch_dimension_address_read(zval *result, z
 
 try_string_offset:
 		if (UNEXPECTED(Z_TYPE_P(dim) != IS_LONG)) {
-			bool is_lax = false;
 			switch (Z_TYPE_P(dim)) {
 				case IS_STRING:
 				{
@@ -2401,8 +2400,6 @@ static zend_always_inline void zend_fetch_dimension_address_read(zval *result, z
 				case IS_FALSE:
 				case IS_TRUE:
 					if (type != BP_VAR_IS) {
-						/* Warning already occurred */
-						is_lax = true;
 						zend_error(E_WARNING, "String offset cast occurred");
 					}
 					break;
@@ -2414,7 +2411,7 @@ static zend_always_inline void zend_fetch_dimension_address_read(zval *result, z
 					break;
 			}
 
-			offset = zval_get_long_func(dim, is_lax);
+			offset = zval_get_long_func(dim, /* is_lax */ true);
 		} else {
 			offset = Z_LVAL_P(dim);
 		}