Fix variance bug where too many errors were suppressed

Author: morrisonlevi

Zend/zend_inheritance.c

@@ -2001,7 +2001,7 @@ static void _inheritance_runtime_error_msg(zend_function *child, zend_function *
 	zend_function *proto = child->common.prototype;
 	if ((proto && (proto->common.fn_flags & ZEND_ACC_ABSTRACT))
 	    || ((parent->common.fn_flags & ZEND_ACC_HAS_RETURN_TYPE)
-	        && !_check_inherited_return_type(child, child->common.arg_info - 1, parent, parent->common.arg_info - 1)))
+	        && _check_inherited_return_type(child, child->common.arg_info - 1, parent, parent->common.arg_info - 1) <= 0))
 	{
 		zend_string *method_prototype = zend_get_function_declaration(parent);
 		zend_string *child_prototype = zend_get_function_declaration(child);
@@ -2041,7 +2041,7 @@ ZEND_API void zend_verify_variance(zend_class_entry *ce) /* {{{ */
 					int check = _check_inherited_return_type(
 						child, &child->common.arg_info[-1],
 						parent, &parent->common.arg_info[-1]);
-					if (check < 0) {
+					if (check <= 0) {
 						_inheritance_runtime_error_msg(child, parent);
 						// todo: what to do with errors, not warnings?
 						continue;
@@ -2082,7 +2082,7 @@ ZEND_API void zend_verify_variance(zend_class_entry *ce) /* {{{ */
 					child, child_arg_info,
 					parent, parent_arg_info);
 
-				if (check < 0) {
+				if (check <= 0) {
 					_inheritance_runtime_error_msg(child, parent);
 					// todo: what to do with errors, not warnings?
 					continue;