Deprecate date_sunrise and date_sunset constants (#12978)

RFC: https://wiki.php.net/rfc/deprecations_php_8_4

Author: jorgsowa

NEWS

@@ -6,6 +6,10 @@ PHP                                                                        NEWS
   . Updated build system scripts config.guess to 2024-07-27 and config.sub to
     2024-05-27. (Peter Kokot)
 
+- Date:
+  . Constants SUNFUNCS_RET_TIMESTAMP, SUNFUNCS_RET_STRING, and SUNFUNCS_RET_DOUBLE
+    are now deprecated. (Jorg Sowa)
+
 - DOM:
   . Fixed bug GH-15192 (Segmentation fault in dom extension
     (html5_serializer)). (nielsdos)

UPGRADING

@@ -404,6 +404,10 @@ PHP 8.4 UPGRADE NOTES
 - Date:
   . Calling DatePeriod::__construct(string $isostr, int $options = 0) is
     deprecated. Use DatePeriod::createFromISO8601String() instead.
+  . Constants SUNFUNCS_RET_TIMESTAMP, SUNFUNCS_RET_STRING, and
+    SUNFUNCS_RET_DOUBLE are now deprecated, following the deprecation of
+    the associated date_sunset() and date_sunrise() functions in PHP 8.1.
+    RFC: https://wiki.php.net/rfc/deprecations_php_8_4
 
 - Intl:
   . Calling intlcal_set() as well as calling IntlCalendar::set() with

ext/date/php_date.stub.php

@@ -83,18 +83,21 @@
 /**
  * @var int
  * @cvalue SUNFUNCS_RET_TIMESTAMP
+ * @deprecated
  */
 const SUNFUNCS_RET_TIMESTAMP = UNKNOWN;
 
 /**
  * @var int
  * @cvalue SUNFUNCS_RET_STRING
+ * @deprecated
  */
 const SUNFUNCS_RET_STRING = UNKNOWN;
 
 /**
  * @var int
  * @cvalue SUNFUNCS_RET_DOUBLE
+ * @deprecated
  */
 const SUNFUNCS_RET_DOUBLE = UNKNOWN;
 

ext/date/php_date_arginfo.h

@@ -25,9 +25,13 @@ var_dump(gettype(date_sunset(time())));
 --EXPECTF--
 Basic test for date_sunrise() and date_sunset()
 
+Deprecated: Constant SUNFUNCS_RET_STRING is deprecated in %s on line %d
+
 Deprecated: Function date_sunrise() is deprecated since 8.1, use date_sun_info() instead in %s on line %d
 %s %s %d %d, sunrise time : %d:%d
 
+Deprecated: Constant SUNFUNCS_RET_STRING is deprecated in %s on line %d
+
 Deprecated: Function date_sunset() is deprecated since 8.1, use date_sun_info() instead in %s on line %d
 %s %s %d %d, sunset time : %d:%d
 

ext/date/tests/date_sunrise_and_sunset_basic.phpt

@@ -29,5 +29,8 @@ foreach (get_declared_classes() as $class) {
 
 ?>
 ===DONE===
---EXPECT--
+--EXPECTF--
+Deprecated: Constant SUNFUNCS_RET_STRING is deprecated in %s on line %d
+
+Deprecated: Constant SUNFUNCS_RET_STRING is deprecated in %s on line %d
 ===DONE===