Skip to content

Commit b9bf9dd

Browse files
dktappsweltling
authored andcommitted
mkdist.php: recursively check dll dependencies
Fix duplication of recursively checked deps
1 parent 6644bd0 commit b9bf9dd

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

win32/build/mkdist.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,11 @@ function get_depends($module)
122122
}
123123
}
124124

125-
$per_module_deps[basename($module)][] = $dep;
125+
if (!isset($per_module_deps[basename($module)]) || !in_array($dep, $per_module_deps[basename($module)])) {
126+
$per_module_deps[basename($module)][] = $dep;
127+
//recursively check dll dependencies
128+
get_depends($dep);
129+
}
126130
}
127131
fclose($pipes[1]);
128132
proc_close($proc);
@@ -335,10 +339,6 @@ function extract_file_from_tarball($pkg, $filename, $dest_dir) /* {{{ */
335339
deps. For example, libenchant.dll loads libenchant_myspell.dll or
336340
libenchant_ispell.dll
337341
*/
338-
$ICU_DLLS = $php_build_dir . '/bin/icu*.dll';
339-
foreach (glob($ICU_DLLS) as $filename) {
340-
copy($filename, "$dist_dir/" . basename($filename));
341-
}
342342
$ENCHANT_DLLS = array(
343343
array('', 'glib-2.dll'),
344344
array('', 'gmodule-2.dll'),

0 commit comments

Comments
 (0)