Skip to content

Commit b859ca2

Browse files
committed
Fix [-Wundef] warning in FileInfo extension
1 parent cfb85d0 commit b859ca2

File tree

4 files changed

+32
-14
lines changed

4 files changed

+32
-14
lines changed

ext/fileinfo/libmagic.patch

Lines changed: 27 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1062,7 +1062,7 @@ diff -u libmagic.orig/buffer.c libmagic/buffer.c
10621062

10631063
diff -u libmagic.orig/cdf.c libmagic/cdf.c
10641064
--- libmagic.orig/cdf.c 2019-02-20 03:35:27.000000000 +0100
1065-
+++ libmagic/cdf.c 2020-04-07 22:25:10.517321000 +0200
1065+
+++ libmagic/cdf.c 2020-05-05 20:05:37.698461100 +0200
10661066
@@ -43,7 +43,17 @@
10671067
#include <err.h>
10681068
#endif
@@ -1395,7 +1395,7 @@ diff -u libmagic.orig/cdf_time.c libmagic/cdf_time.c
13951395
(void)snprintf(buf, 26, "*Bad* %#16.16" INT64_T_FORMAT "x\n",
13961396
diff -u libmagic.orig/compress.c libmagic/compress.c
13971397
--- libmagic.orig/compress.c 2019-05-07 04:27:11.000000000 +0200
1398-
+++ libmagic/compress.c 2020-04-07 22:25:10.517321000 +0200
1398+
+++ libmagic/compress.c 2020-05-20 18:00:58.381264900 +0200
13991399
@@ -45,13 +45,11 @@
14001400
#endif
14011401
#include <string.h>
@@ -1437,6 +1437,15 @@ diff -u libmagic.orig/compress.c libmagic/compress.c
14371437

14381438
static const char *gzip_args[] = {
14391439
"gzip", gzip_flags, NULL
1440+
@@ -178,7 +178,7 @@
1441+
#define ERRDATA 2
1442+
1443+
private ssize_t swrite(int, const void *, size_t);
1444+
-#if HAVE_FORK
1445+
+#ifdef HAVE_FORK
1446+
private size_t ncompr = __arraycount(compr);
1447+
private int uncompressbuf(int, size_t, size_t, const unsigned char *,
1448+
unsigned char **, size_t *);
14401449
@@ -193,8 +193,7 @@
14411450
size_t *, int);
14421451
#endif
@@ -1636,7 +1645,7 @@ diff -u libmagic.orig/encoding.c libmagic/encoding.c
16361645
}
16371646
diff -u libmagic.orig/file.h libmagic/file.h
16381647
--- libmagic.orig/file.h 2019-05-07 04:27:11.000000000 +0200
1639-
+++ libmagic/file.h 2020-04-22 20:15:46.790840100 +0200
1648+
+++ libmagic/file.h 2020-05-20 16:42:45.933197800 +0200
16401649
@@ -33,18 +33,9 @@
16411650
#ifndef __file_h__
16421651
#define __file_h__
@@ -1703,6 +1712,15 @@ diff -u libmagic.orig/file.h libmagic/file.h
17031712
#define PATHSEP ';'
17041713
#else
17051714
#define PATHSEP ':'
1715+
@@ -90,7 +90,7 @@
1716+
1717+
#define private static
1718+
1719+
-#if HAVE_VISIBILITY && !defined(WIN32)
1720+
+#if defined(HAVE_VISIBILITY) && !defined(WIN32)
1721+
#define public __attribute__ ((__visibility__("default")))
1722+
#ifndef protected
1723+
#define protected __attribute__ ((__visibility__("hidden")))
17061724
@@ -116,12 +116,6 @@
17071725
#endif
17081726
#endif
@@ -2212,7 +2230,7 @@ diff -u libmagic.orig/fsmagic.c libmagic/fsmagic.c
22122230
case S_IFSOCK:
22132231
diff -u libmagic.orig/funcs.c libmagic/funcs.c
22142232
--- libmagic.orig/funcs.c 2019-05-07 04:27:11.000000000 +0200
2215-
+++ libmagic/funcs.c 2020-04-14 17:15:50.737587100 +0200
2233+
+++ libmagic/funcs.c 2020-05-20 16:42:45.937726200 +0200
22162234
@@ -31,87 +31,80 @@
22172235
#endif /* lint */
22182236

@@ -2385,7 +2403,7 @@ diff -u libmagic.orig/funcs.c libmagic/funcs.c
23852403
-#if HAVE_FORK
23862404
- /* try compression stuff */
23872405
+
2388-
+#if PHP_FILEINFO_UNCOMPRESS
2406+
+#ifdef PHP_FILEINFO_UNCOMPRESS
23892407
if ((ms->flags & MAGIC_NO_CHECK_COMPRESS) == 0) {
23902408
m = file_zmagic(ms, &b, inname);
23912409
if ((ms->flags & MAGIC_DEBUG) != 0)
@@ -2394,7 +2412,7 @@ diff -u libmagic.orig/funcs.c libmagic/funcs.c
23942412
rv = -1;
23952413
}
23962414
-#if HAVE_FORK
2397-
+#if PHP_FILEINFO_UNCOMPRESS
2415+
+#ifdef PHP_FILEINFO_UNCOMPRESS
23982416
done_encoding:
23992417
#endif
24002418
- free(rbuf);
@@ -2435,7 +2453,7 @@ diff -u libmagic.orig/funcs.c libmagic/funcs.c
24352453
ms->o.pbuf = pbuf;
24362454

24372455
-#if defined(HAVE_WCHAR_H) && defined(HAVE_MBRTOWC) && defined(HAVE_WCWIDTH)
2438-
+#if defined(HAVE_WCWIDTH)
2456+
+#ifdef HAVE_WCWIDTH
24392457
{
24402458
mbstate_t state;
24412459
wchar_t nextchar;
@@ -3048,7 +3066,7 @@ diff -u libmagic.orig/magic.c libmagic/magic.c
30483066
public const char *
30493067
magic_error(struct magic_set *ms)
30503068
diff -u libmagic.orig/magic.h libmagic/magic.h
3051-
--- libmagic.orig/magic.h 2020-04-22 20:17:15.432186600 +0200
3069+
--- libmagic.orig/magic.h 2020-05-20 18:02:37.550664700 +0200
30523070
+++ libmagic/magic.h 2020-04-07 22:25:10.548560600 +0200
30533071
@@ -124,6 +124,7 @@
30543072

@@ -3253,7 +3271,7 @@ diff -u libmagic.orig/readcdf.c libmagic/readcdf.c
32533271
if (i != -1)
32543272
diff -u libmagic.orig/softmagic.c libmagic/softmagic.c
32553273
--- libmagic.orig/softmagic.c 2019-05-17 04:24:59.000000000 +0200
3256-
+++ libmagic/softmagic.c 2020-04-07 22:25:10.548560600 +0200
3274+
+++ libmagic/softmagic.c 2020-04-26 00:43:35.734037100 +0200
32573275
@@ -43,6 +43,10 @@
32583276
#include <time.h>
32593277
#include "der.h"

ext/fileinfo/libmagic/compress.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ private const struct {
178178
#define ERRDATA 2
179179

180180
private ssize_t swrite(int, const void *, size_t);
181-
#if HAVE_FORK
181+
#ifdef HAVE_FORK
182182
private size_t ncompr = __arraycount(compr);
183183
private int uncompressbuf(int, size_t, size_t, const unsigned char *,
184184
unsigned char **, size_t *);

ext/fileinfo/libmagic/file.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@
9090

9191
#define private static
9292

93-
#if HAVE_VISIBILITY && !defined(WIN32)
93+
#if defined(HAVE_VISIBILITY) && !defined(WIN32)
9494
#define public __attribute__ ((__visibility__("default")))
9595
#ifndef protected
9696
#define protected __attribute__ ((__visibility__("hidden")))

ext/fileinfo/libmagic/funcs.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -255,7 +255,7 @@ file_buffer(struct magic_set *ms, php_stream *stream, zend_stat_t *st,
255255
}
256256
#endif
257257

258-
#if PHP_FILEINFO_UNCOMPRESS
258+
#ifdef PHP_FILEINFO_UNCOMPRESS
259259
if ((ms->flags & MAGIC_NO_CHECK_COMPRESS) == 0) {
260260
m = file_zmagic(ms, &b, inname);
261261
if ((ms->flags & MAGIC_DEBUG) != 0)
@@ -367,7 +367,7 @@ file_buffer(struct magic_set *ms, php_stream *stream, zend_stat_t *st,
367367
if (file_printf(ms, "%s", code_mime) == -1)
368368
rv = -1;
369369
}
370-
#if PHP_FILEINFO_UNCOMPRESS
370+
#ifdef PHP_FILEINFO_UNCOMPRESS
371371
done_encoding:
372372
#endif
373373
efree(rbuf);
@@ -434,7 +434,7 @@ file_getbuffer(struct magic_set *ms)
434434
}
435435
ms->o.pbuf = pbuf;
436436

437-
#if defined(HAVE_WCWIDTH)
437+
#ifdef HAVE_WCWIDTH
438438
{
439439
mbstate_t state;
440440
wchar_t nextchar;

0 commit comments

Comments
 (0)