Skip to content

Commit b835791

Browse files
committed
Add some todo comments
1 parent 082c339 commit b835791

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed

ext/intl/calendar/calendar_methods.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -175,6 +175,7 @@ U_CFUNC PHP_FUNCTION(intlcal_get_keyword_values_for_locale)
175175
}
176176

177177
//does not work; see ICU bug 9194
178+
// TODO This was fixed in ICU 50.1 see: https://unicode-org.atlassian.net/browse/ICU-9194
178179
#if 0
179180
StringEnumeration *se = Calendar::getKeywordValuesForLocale(key,
180181
Locale::createFromName(locale), (UBool)commonly_used,

ext/intl/collator/collator_convert.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -194,6 +194,7 @@ zval* collator_convert_zstr_utf8_to_utf16( zval* utf8_zval, zval *rv )
194194
&ustr, &ustr_len,
195195
Z_STRVAL_P( utf8_zval ), Z_STRLEN_P( utf8_zval ),
196196
&status );
197+
// FIXME Or throw error or use intl internal error handler
197198
if( U_FAILURE( status ) )
198199
php_error( E_WARNING, "Error casting object to string in collator_convert_zstr_utf8_to_utf16()" );
199200

@@ -244,6 +245,7 @@ zval* collator_convert_object_to_string( zval* obj, zval *rv )
244245
&ustr, &ustr_len,
245246
Z_STRVAL_P( zstr ), Z_STRLEN_P( zstr ),
246247
&status );
248+
// FIXME Or throw error or use intl internal error handler
247249
if( U_FAILURE( status ) )
248250
php_error( E_WARNING, "Error casting object to string in collator_convert_object_to_string()" );
249251

0 commit comments

Comments
 (0)