Avoid needless string duplication

cmb69 · cmb69 · commit b7b3a65e1db2 · 2018-11-07T17:10:35.000+01:00
Cf. <#3636 (comment)>.
diff --git a/ext/sqlite3/sqlite3.c b/ext/sqlite3/sqlite3.c
@@ -1415,7 +1415,7 @@ static int register_bound_parameter_to_sqlite(struct php_sqlite3_bound_param *pa
 			memmove(ZSTR_VAL(temp) + 1, ZSTR_VAL(param->name), ZSTR_LEN(param->name) + 1);
 			param->name = temp;
 		} else {
-			param->name = zend_string_init(ZSTR_VAL(param->name), ZSTR_LEN(param->name), 0);
+			param->name = zend_string_copy(param->name);
 		}
 		/* do lookup*/
 		param->param_number = sqlite3_bind_parameter_index(stmt->stmt, ZSTR_VAL(param->name));

Original file line number	Diff line number	Diff line change
`@@ -1415,7 +1415,7 @@ static int register_bound_parameter_to_sqlite(struct php_sqlite3_bound_param *pa`
`1415`	`1415`	`memmove(ZSTR_VAL(temp) + 1, ZSTR_VAL(param->name), ZSTR_LEN(param->name) + 1);`
`1416`	`1416`	`param->name = temp;`
`1417`	`1417`	`} else {`
`1418`		`- param->name = zend_string_init(ZSTR_VAL(param->name), ZSTR_LEN(param->name), 0);`
	`1418`	`+ param->name = zend_string_copy(param->name);`
`1419`	`1419`	`}`
`1420`	`1420`	`/* do lookup*/`
`1421`	`1421`	`param->param_number = sqlite3_bind_parameter_index(stmt->stmt, ZSTR_VAL(param->name));`