Free RSA public key in mysqlnd sha256 auth

nikic · nikic · commit b6a59cee474f · 2019-12-11T10:31:56.000+01:00
Not sure why this only started showing up as a leak now.
diff --git a/ext/mysqlnd/mysqlnd_auth.c b/ext/mysqlnd/mysqlnd_auth.c
@@ -810,6 +810,7 @@ mysqlnd_sha256_auth_get_auth_data(struct st_mysqlnd_authentication_plugin * self
 			*auth_data_len = server_public_key_len;
 			ret = malloc(*auth_data_len);
 			RSA_public_encrypt(passwd_len + 1, (zend_uchar *) xor_str, ret, server_public_key, RSA_PKCS1_OAEP_PADDING);
+			RSA_free(server_public_key);
 		}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -810,6 +810,7 @@ mysqlnd_sha256_auth_get_auth_data(struct st_mysqlnd_authentication_plugin * self`
`810`	`810`	`*auth_data_len = server_public_key_len;`
`811`	`811`	`ret = malloc(*auth_data_len);`
`812`	`812`	`RSA_public_encrypt(passwd_len + 1, (zend_uchar *) xor_str, ret, server_public_key, RSA_PKCS1_OAEP_PADDING);`
	`813`	`+ RSA_free(server_public_key);`
`813`	`814`	`}`
`814`	`815`	`}`
`815`	`816`