Fix GH-9967 Add support for generating custom function attributes in stubs

Author: kocsismate

build/gen_stub.php

@@ -1185,8 +1185,11 @@ class FuncInfo {
     public int $numRequiredArgs;
     public ?string $cond;
     public bool $isUndocumentable;
+    /** @var AttributeInfo[] */
+    public array $attributes;
 
     /**
+     * @param AttributeInfo[] $attributes
      * @param ArgInfo[] $args
      */
     public function __construct(
@@ -1202,7 +1205,8 @@ public function __construct(
         ReturnInfo $return,
         int $numRequiredArgs,
         ?string $cond,
-        bool $isUndocumentable
+        bool $isUndocumentable,
+        array $attributes
     ) {
         $this->name = $name;
         $this->classFlags = $classFlags;
@@ -1217,6 +1221,7 @@ public function __construct(
         $this->numRequiredArgs = $numRequiredArgs;
         $this->cond = $cond;
         $this->isUndocumentable = $isUndocumentable;
+        $this->attributes = $attributes;
     }
 
     public function isMethod(): bool
@@ -1412,6 +1417,7 @@ public function getOptimizerInfo(): ?string {
     }
 
     public function discardInfoForOldPhpVersions(): void {
+        $this->attributes = [];
         $this->return->type = null;
         foreach ($this->args as $arg) {
             $arg->type = null;
@@ -3221,17 +3227,24 @@ function parseFunctionLike(
             }
         }
 
+        $attributes = [];
+        foreach ($func->attrGroups as $attrGroup) {
+            foreach ($attrGroup->attrs as $attr) {
+                $attributes[] = new AttributeInfo($attr->name->toString(), $attr->args);
+            }
+        }
+
         $varNameSet = [];
         $args = [];
         $numRequiredArgs = 0;
         $foundVariadic = false;
         foreach ($func->getParams() as $i => $param) {
             $varName = $param->var->name;
             $preferRef = !empty($paramMeta[$varName]['prefer-ref']);
-            $attributes = [];
+            $paramAttributes = [];
             foreach ($param->attrGroups as $attrGroup) {
                 foreach ($attrGroup->attrs as $attr) {
-                    $attributes[] = new AttributeInfo($attr->name->toString(), $attr->args);
+                    $paramAttributes[] = new AttributeInfo($attr->name->toString(), $attr->args);
                 }
             }
             unset($paramMeta[$varName]);
@@ -3281,7 +3294,7 @@ function parseFunctionLike(
                 $type,
                 isset($docParamTypes[$varName]) ? Type::fromString($docParamTypes[$varName]) : null,
                 $param->default ? $prettyPrinter->prettyPrintExpr($param->default) : null,
-                $attributes
+                $paramAttributes
             );
             if (!$param->default && !$param->variadic) {
                 $numRequiredArgs = $i + 1;
@@ -3318,7 +3331,8 @@ function parseFunctionLike(
             $return,
             $numRequiredArgs,
             $cond,
-            $isUndocumentable
+            $isUndocumentable,
+            $attributes
         );
     } catch (Exception $e) {
         throw new Exception($name . "(): " .$e->getMessage());
@@ -4040,13 +4054,17 @@ function generateAttributeInitialization(iterable $funcInfos, iterable $allConst
         static function (FuncInfo $funcInfo) use ($allConstInfos) {
             $code = null;
 
-            foreach ($funcInfo->args as $index => $arg) {
-                if ($funcInfo->name instanceof MethodName) {
-                    $functionTable = "&class_entry->function_table";
-                } else {
-                    $functionTable = "CG(function_table)";
-                }
+            if ($funcInfo->name instanceof MethodName) {
+                $functionTable = "&class_entry->function_table";
+            } else {
+                $functionTable = "CG(function_table)";
+            }
+
+            foreach ($funcInfo->attributes as $attribute) {
+                $code .= $attribute->generateCode("zend_add_function_attribute(zend_hash_str_find_ptr($functionTable, \"" . $funcInfo->name->getNameForAttributes() . "\", sizeof(\"" . $funcInfo->name->getNameForAttributes() . "\") - 1)", $funcInfo->name->getMethodSynopsisFilename(), $allConstInfos);
+            }
 
+            foreach ($funcInfo->args as $index => $arg) {
                 foreach ($arg->attributes as $attribute) {
                     $code .= $attribute->generateCode("zend_add_parameter_attribute(zend_hash_str_find_ptr($functionTable, \"" . $funcInfo->name->getNameForAttributes() . "\", sizeof(\"" . $funcInfo->name->getNameForAttributes() . "\") - 1), $index", "{$funcInfo->name->getMethodSynopsisFilename()}_arg{$index}", $allConstInfos);
                 }

ext/zend_test/test.stub.php

@@ -51,6 +51,7 @@ trait _ZendTestTrait {
         /** @var mixed */
         public $testProp;
 
+        #[Attribute(Attribute::TARGET_METHOD)]
         public function testMethod(): bool {}
     }