Skip to content

Commit b4f7f24

Browse files
committed
Remove a part of comments
It seems unlikely that this line will be overlooked when someone changes the implementation of access controls of trait constants. But it might be possible when changing the destruction of class entries. So it may cause unnecessary misunderstandings in the future. And if one wants to know the timing of destruction, seeing the actual implementation destructing class entries would be needed anyway.
1 parent 7e698c0 commit b4f7f24

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

Zend/zend_inheritance.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2284,10 +2284,6 @@ static void zend_do_traits_constant_binding(zend_class_entry *ce, zend_class_ent
22842284
/* Unlike interface implementations and class inheritances,
22852285
* access control of the trait constants is done by the scope
22862286
* of the composing class. So let's replace the ce here.
2287-
* And the result of this, the values, doc comments, and
2288-
* attributes associated with the copied zend_class_constant
2289-
* are destroyed at the time of destroying the class entry of
2290-
* the composing class.
22912287
*/
22922288
constant->ce = ce;
22932289

0 commit comments

Comments
 (0)