Revert "Make empty strings an error"

This reverts commit 75c76d6.

Author: Girgias

ext/standard/array.c

@@ -2716,8 +2716,14 @@ static uint8_t php_range_process_input(const zval *input, uint32_t arg_num, zend
 			return IS_DOUBLE;
 		case IS_STRING: {
 			if (Z_STRLEN_P(input) == 0) {
-				zend_argument_value_error(arg_num, "must not be empty");
-				return 0;
+				const char *arg_name = get_active_function_arg_name(arg_num);
+				php_error_docref(NULL, E_WARNING, "Argument #%d ($%s) must not be empty, casted to 0", arg_num, arg_name);
+				if (UNEXPECTED(EG(exception))) {
+					return 0;
+				}
+				*lval = 0;
+				*dval = 0.0;
+				return IS_LONG;
 			}
 			uint8_t type = is_numeric_str_function(Z_STR_P(input), lval, dval);
 			if (type == IS_DOUBLE) {

ext/standard/tests/array/range/bug32021.phpt

@@ -0,0 +1,17 @@
+--TEST--
+Bug #32021 (Crash caused by range('', 'z'))
+--FILE--
+<?php
+$foo = range('', 'z');
+var_dump($foo);
+?>
+ALIVE
+--EXPECTF--
+Warning: range(): Argument #1 ($start) must not be empty, casted to 0 in %s on line %d
+
+Warning: range(): Argument #1 ($start) must be a string if argument #2 ($end) is a string, argument #2 ($end) converted to 0 in %s on line %d
+array(1) {
+  [0]=>
+  int(0)
+}
+ALIVE

ext/standard/tests/array/range/range_inputs_string_invalid.phpt

@@ -9,16 +9,8 @@ echo "Range will ignore any byte after the first one\n";
 var_dump( range("AA", "BB") );
 
 echo "Range cannot operate on an empty string\n";
-try {
-    var_dump( range("Z", "") );
-} catch (ValueError $e) {
-    echo $e->getMessage(), "\n";
-}
-try {
-    var_dump( range("", "Z") );
-} catch (ValueError $e) {
-    echo $e->getMessage(), "\n";
-}
+var_dump( range("Z", "") ); // Both strings are cast to int, i.e. 0
+var_dump( range("", "Z") ); // Both strings are cast to int, i.e. 0
 
 echo "Mixing numeric string and character\n";
 var_dump( range("1", "A") ); // The char is cast to an int, i.e. 0
@@ -44,8 +36,22 @@ array(2) {
   string(1) "B"
 }
 Range cannot operate on an empty string
-range(): Argument #2 ($end) must not be empty
-range(): Argument #1 ($start) must not be empty
+
+Warning: range(): Argument #2 ($end) must not be empty, casted to 0 in %s on line %d
+
+Warning: range(): Argument #2 ($end) must be a string if argument #1 ($start) is a string, argument #1 ($start) converted to 0 in %s on line %d
+array(1) {
+  [0]=>
+  int(0)
+}
+
+Warning: range(): Argument #1 ($start) must not be empty, casted to 0 in %s on line %d
+
+Warning: range(): Argument #1 ($start) must be a string if argument #2 ($end) is a string, argument #2 ($end) converted to 0 in %s on line %d
+array(1) {
+  [0]=>
+  int(0)
+}
 Mixing numeric string and character
 
 Warning: range(): Argument #1 ($start) must be a string if argument #2 ($end) is a string, argument #2 ($end) converted to 0 in %s on line %d