Promote warnings to exceptions in dl() function

Author: kocsismate

ext/standard/dl.c

@@ -50,13 +50,13 @@ PHPAPI PHP_FUNCTION(dl)
 	ZEND_PARSE_PARAMETERS_END();
 
 	if (!PG(enable_dl)) {
-		php_error_docref(NULL, E_WARNING, "Dynamically loaded extensions aren't enabled");
-		RETURN_FALSE;
+		zend_throw_error(NULL, "Dynamically loaded extensions aren't enabled");
+		return;
 	}
 
 	if (filename_len >= MAXPATHLEN) {
-		php_error_docref(NULL, E_WARNING, "File name exceeds the maximum allowed length of %d characters", MAXPATHLEN);
-		RETURN_FALSE;
+		zend_value_error("File name exceeds the maximum allowed length of %d characters", MAXPATHLEN);
+		return;
 	}
 
 	php_dl(filename, MODULE_TEMPORARY, return_value, 0);
@@ -265,7 +265,7 @@ PHP_MINFO_FUNCTION(dl)
 
 PHPAPI void php_dl(char *file, int type, zval *return_value, int start_now)
 {
-	php_error_docref(NULL, E_WARNING, "Cannot dynamically load %s - dynamic modules are not supported", file);
+	zend_throw_error(NULL, "Cannot dynamically load %s - dynamic modules are not supported", file);
 	RETVAL_FALSE;
 }
 

ext/standard/tests/general_functions/dl-check-enabled.phpt

@@ -1,6 +1,6 @@
 --TEST--
 dl() returns false when disabled via INI settings
-+--CREDITS--
+--CREDITS--
 Tom Van Herreweghe <tom@theanalogguy.be>
 User Group: PHP-WVL & PHPGent #PHPTestFest
 --SKIPIF--
@@ -14,9 +14,11 @@ if (!in_array(php_sapi_name(), $enabled_sapi)) {
 enable_dl=0
 --FILE--
 <?php
-var_dump(dl('foo'));
+try {
+    dl('foo');
+} catch (Error $exception) {
+    echo $exception->getMessage() . "\n";
+}
 ?>
---EXPECTF--
-
-Warning: dl(): Dynamically loaded extensions aren't enabled in %s on line %d
-bool(false)
+--EXPECT--
+Dynamically loaded extensions aren't enabled

ext/standard/tests/general_functions/dl-cve-2007-4887.phpt

@@ -11,8 +11,11 @@ if (!in_array(php_sapi_name(), $enabled_sapi)) {
 enable_dl=1
 --FILE--
 <?php
-var_dump(dl(str_repeat("a", 8376757)));
+try {
+    dl(str_repeat("a", 8376757));
+} catch (ValueError $exception) {
+    echo $exception->getMessage() . "\n";
+}
 ?>
 --EXPECTF--
-Warning: dl(): File name exceeds the maximum allowed length of %d characters in %s on line %d
-bool(false)
+File name exceeds the maximum allowed length of %d characters