Skip to content

Commit addc78f

Browse files
committed
Revert "Add missing zend_parse_parameters_none()"
This reverts commit ef439ec. Test failures need to be resolved first.
1 parent ef439ec commit addc78f

File tree

1 file changed

+0
-45
lines changed

1 file changed

+0
-45
lines changed

ext/reflection/php_reflection.c

Lines changed: 0 additions & 45 deletions
Original file line numberDiff line numberDiff line change
@@ -1649,11 +1649,6 @@ ZEND_METHOD(reflection_function, isDisabled)
16491649
zend_function *fptr;
16501650

16511651
GET_REFLECTION_OBJECT_PTR(fptr);
1652-
1653-
if (zend_parse_parameters_none() == FAILURE) {
1654-
return;
1655-
}
1656-
16571652
RETURN_BOOL(fptr->type == ZEND_INTERNAL_FUNCTION && fptr->internal_function.handler == zif_display_disabled_function);
16581653
}
16591654
/* }}} */
@@ -1895,10 +1890,6 @@ ZEND_METHOD(reflection_function, returnsReference)
18951890

18961891
GET_REFLECTION_OBJECT_PTR(fptr);
18971892

1898-
if (zend_parse_parameters_none() == FAILURE) {
1899-
return;
1900-
}
1901-
19021893
RETURN_BOOL((fptr->op_array.fn_flags & ZEND_ACC_RETURN_REFERENCE) != 0);
19031894
}
19041895
/* }}} */
@@ -1913,10 +1904,6 @@ ZEND_METHOD(reflection_function, getNumberOfParameters)
19131904

19141905
GET_REFLECTION_OBJECT_PTR(fptr);
19151906

1916-
if (zend_parse_parameters_none() == FAILURE) {
1917-
return;
1918-
}
1919-
19201907
num_args = fptr->common.num_args;
19211908
if (fptr->common.fn_flags & ZEND_ACC_VARIADIC) {
19221909
num_args++;
@@ -1935,10 +1922,6 @@ ZEND_METHOD(reflection_function, getNumberOfRequiredParameters)
19351922

19361923
GET_REFLECTION_OBJECT_PTR(fptr);
19371924

1938-
if (zend_parse_parameters_none() == FAILURE) {
1939-
return;
1940-
}
1941-
19421925
RETURN_LONG(fptr->common.required_num_args);
19431926
}
19441927
/* }}} */
@@ -1954,10 +1937,6 @@ ZEND_METHOD(reflection_function, getParameters)
19541937

19551938
GET_REFLECTION_OBJECT_PTR(fptr);
19561939

1957-
if (zend_parse_parameters_none() == FAILURE) {
1958-
return;
1959-
}
1960-
19611940
arg_info= fptr->common.arg_info;
19621941
num_args = fptr->common.num_args;
19631942
if (fptr->common.fn_flags & ZEND_ACC_VARIADIC) {
@@ -1997,10 +1976,6 @@ ZEND_METHOD(reflection_function, getExtension)
19971976

19981977
GET_REFLECTION_OBJECT_PTR(fptr);
19991978

2000-
if (zend_parse_parameters_none() == FAILURE) {
2001-
return;
2002-
}
2003-
20041979
if (fptr->type != ZEND_INTERNAL_FUNCTION) {
20051980
RETURN_NULL();
20061981
}
@@ -2024,10 +1999,6 @@ ZEND_METHOD(reflection_function, getExtensionName)
20241999

20252000
GET_REFLECTION_OBJECT_PTR(fptr);
20262001

2027-
if (zend_parse_parameters_none() == FAILURE) {
2028-
return;
2029-
}
2030-
20312002
if (fptr->type != ZEND_INTERNAL_FUNCTION) {
20322003
RETURN_FALSE;
20332004
}
@@ -3013,10 +2984,6 @@ ZEND_METHOD(reflection_method, getClosure)
30132984
GET_REFLECTION_OBJECT_PTR(mptr);
30142985

30152986
if (mptr->common.fn_flags & ZEND_ACC_STATIC) {
3016-
if (zend_parse_parameters_none() == FAILURE) {
3017-
return;
3018-
}
3019-
30202987
zend_create_fake_closure(return_value, mptr, mptr->common.scope, mptr->common.scope, NULL);
30212988
} else {
30222989
if (zend_parse_parameters(ZEND_NUM_ARGS(), "o", &obj) == FAILURE) {
@@ -4676,10 +4643,6 @@ ZEND_METHOD(reflection_class, newInstanceWithoutConstructor)
46764643

46774644
GET_REFLECTION_OBJECT_PTR(ce);
46784645

4679-
if (zend_parse_parameters_none() == FAILURE) {
4680-
return;
4681-
}
4682-
46834646
if (ce->type == ZEND_INTERNAL_CLASS
46844647
&& ce->create_object != NULL && (ce->ce_flags & ZEND_ACC_FINAL)) {
46854648
zend_throw_exception_ex(reflection_exception_ptr, 0, "Class %s is an internal class marked as final that cannot be instantiated without invoking its constructor", ZSTR_VAL(ce->name));
@@ -5415,10 +5378,6 @@ ZEND_METHOD(reflection_property, getValue)
54155378
}
54165379

54175380
if (ref->prop.flags & ZEND_ACC_STATIC) {
5418-
if (zend_parse_parameters_none() == FAILURE) {
5419-
return;
5420-
}
5421-
54225381
member_p = zend_read_static_property_ex(intern->ce, ref->unmangled_name, 0);
54235382
if (member_p) {
54245383
ZVAL_COPY_DEREF(return_value, member_p);
@@ -5504,10 +5463,6 @@ ZEND_METHOD(reflection_property, isInitialized)
55045463
}
55055464

55065465
if (ref->prop.flags & ZEND_ACC_STATIC) {
5507-
if (zend_parse_parameters_none() == FAILURE) {
5508-
return;
5509-
}
5510-
55115466
member_p = zend_read_static_property_ex(intern->ce, ref->unmangled_name, 1);
55125467
if (member_p) {
55135468
RETURN_BOOL(!Z_ISUNDEF_P(member_p));

0 commit comments

Comments
 (0)