Reduce ZPP API overhead

dstogov · dstogov · commit ac7e967b6758 · 2021-02-20T13:59:29.000+03:00
diff --git a/ext/opcache/zend_accelerator_module.c b/ext/opcache/zend_accelerator_module.c
@@ -332,15 +332,14 @@ static int filename_is_in_cache(zend_string *filename)
 
 static int accel_file_in_cache(INTERNAL_FUNCTION_PARAMETERS)
 {
-	zval zfilename;
+	if (ZEND_NUM_ARGS() == 1) {
+		zval *zv = ZEND_CALL_ARG(execute_data , 1);
 
-	if (ZEND_NUM_ARGS() != 1 ||
-	    zend_get_parameters_array_ex(1, &zfilename) == FAILURE ||
-	    Z_TYPE(zfilename) != IS_STRING ||
-	    Z_STRLEN(zfilename) == 0) {
-		return 0;
+		if (Z_TYPE_P(zv) == IS_STRING && Z_STRLEN_P(zv) != 0) {
+			return filename_is_in_cache(Z_STR_P(zv));
+		}
 	}
-	return filename_is_in_cache(Z_STR(zfilename));
+	return 0;
 }
 
 static ZEND_NAMED_FUNCTION(accel_file_exists)

Original file line number	Diff line number	Diff line change
`@@ -332,15 +332,14 @@ static int filename_is_in_cache(zend_string *filename)`
`332`	`332`
`333`	`333`	`static int accel_file_in_cache(INTERNAL_FUNCTION_PARAMETERS)`
`334`	`334`	`{`
`335`		`- zval zfilename;`
	`335`	`+ if (ZEND_NUM_ARGS() == 1) {`
	`336`	`+ zval *zv = ZEND_CALL_ARG(execute_data , 1);`
`336`	`337`
`337`		`- if (ZEND_NUM_ARGS() != 1 \|\|`
`338`		`- zend_get_parameters_array_ex(1, &zfilename) == FAILURE \|\|`
`339`		`- Z_TYPE(zfilename) != IS_STRING \|\|`
`340`		`- Z_STRLEN(zfilename) == 0) {`
`341`		`- return 0;`
	`338`	`+ if (Z_TYPE_P(zv) == IS_STRING && Z_STRLEN_P(zv) != 0) {`
	`339`	`+ return filename_is_in_cache(Z_STR_P(zv));`
	`340`	`+ }`
`342`	`341`	`}`
`343`		`- return filename_is_in_cache(Z_STR(zfilename));`
	`342`	`+ return 0;`
`344`	`343`	`}`
`345`	`344`
`346`	`345`	`static ZEND_NAMED_FUNCTION(accel_file_exists)`