Fix reflection check

nielsdos · nielsdos · commit ac42c8b15e1b · 2024-07-27T17:25:12.000+02:00
diff --git a/ext/reflection/php_reflection.c b/ext/reflection/php_reflection.c
@@ -6041,7 +6041,7 @@ ZEND_METHOD(ReflectionProperty, getSettableType)
 	}
 
 	/* Get-only virtual property can never be written to. */
-	if (prop->hooks && !prop->hooks[ZEND_PROPERTY_HOOK_SET]) {
+	if (prop->hooks && (prop->flags & ZEND_ACC_VIRTUAL) && !prop->hooks[ZEND_PROPERTY_HOOK_SET]) {
 		zend_type never_type = ZEND_TYPE_INIT_CODE(IS_NEVER, 0, 0);
 		reflection_type_factory(never_type, return_value, 0);
 		return;

Original file line number	Diff line number	Diff line change
`@@ -6041,7 +6041,7 @@ ZEND_METHOD(ReflectionProperty, getSettableType)`
`6041`	`6041`	`}`
`6042`	`6042`
`6043`	`6043`	`/* Get-only virtual property can never be written to. */`
`6044`		`- if (prop->hooks && !prop->hooks[ZEND_PROPERTY_HOOK_SET]) {`
	`6044`	`+ if (prop->hooks && (prop->flags & ZEND_ACC_VIRTUAL) && !prop->hooks[ZEND_PROPERTY_HOOK_SET]) {`
`6045`	`6045`	`zend_type never_type = ZEND_TYPE_INIT_CODE(IS_NEVER, 0, 0);`
`6046`	`6046`	`reflection_type_factory(never_type, return_value, 0);`
`6047`	`6047`	`return;`