Skip to content

Commit a836bae

Browse files
committed
Merge branch 'PHP-8.2'
* PHP-8.2: [skip ci] Skip function JIT in nightly for ASAN
2 parents 894f87d + ac05c8f commit a836bae

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

.github/nightly_matrix.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ function get_matrix_include(array $branches) {
5252
'zts' => true,
5353
'configuration_parameters' => "CFLAGS='-fsanitize=undefined,address -DZEND_TRACK_ARENA_ALLOC' LDFLAGS='-fsanitize=undefined,address'",
5454
'run_tests_parameters' => '--asan',
55-
'timeout_minutes' => 480,
55+
'test_function_jit' => false,
5656
];
5757
if ($branch['ref'] !== 'PHP-8.0') {
5858
$jobs[] = [
@@ -62,6 +62,7 @@ function get_matrix_include(array $branches) {
6262
'zts' => false,
6363
'run_tests_parameters' => '--repeat 2',
6464
'timeout_minutes' => 360,
65+
'test_function_jit' => true,
6566
];
6667
$jobs[] = [
6768
'name' => '_VARIATION',
@@ -70,6 +71,7 @@ function get_matrix_include(array $branches) {
7071
'zts' => true,
7172
'configuration_parameters' => "CFLAGS='-DZEND_RC_DEBUG=1 -DPROFITABILITY_CHECKS=0 -DZEND_VERIFY_FUNC_INFO=1'",
7273
'timeout_minutes' => 360,
74+
'test_function_jit' => true,
7375
];
7476
}
7577
}

.github/workflows/nightly.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,12 +43,11 @@ jobs:
4343
debug: [true, false]
4444
name: ['']
4545
run_tests_parameters: ['']
46-
timeout_minutes: [360]
46+
test_function_jit: [true]
4747
zts: [true, false]
4848
include: ${{ fromJson(needs.GENERATE_MATRIX.outputs.matrix-include) }}
4949
name: "${{ matrix.branch.name }}_LINUX_X64${{ matrix.name }}_${{ matrix.debug && 'DEBUG' || 'RELEASE' }}_${{ matrix.zts && 'ZTS' || 'NTS' }}"
5050
runs-on: ubuntu-20.04
51-
timeout-minutes: ${{ matrix.timeout_minutes }}
5251
steps:
5352
- name: git checkout
5453
uses: actions/checkout@v3
@@ -97,6 +96,9 @@ jobs:
9796
-d zend_extension=opcache.so
9897
-d opcache.enable_cli=1
9998
- name: Test Function JIT
99+
# ASAN frequently timeouts. Each test run takes ~90 minutes, we can
100+
# avoid running into the 6 hour timeout by skipping the function JIT.
101+
if: matrix.test_function_jit
100102
uses: ./.github/actions/test-linux
101103
with:
102104
testArtifacts: ${{ matrix.branch.name }}_${{ matrix.name }}_${{ matrix.debug && 'DEBUG' || 'RELEASE' }}_${{ matrix.zts && 'ZTS' || 'NTS' }} Function JIT

0 commit comments

Comments
 (0)