Skip to content

Commit a6f2619

Browse files
committed
[W.I.P] ext/mbstring: Add some TODO
1 parent e6d9544 commit a6f2619

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

ext/mbstring/mbstring.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -542,6 +542,7 @@ static void _php_mb_free_regex(void *opaque)
542542
}
543543
/* }}} */
544544

545+
// TODO make void as return value is ignored?
545546
/* {{{ php_mb_nls_get_default_detect_order_list */
546547
static int php_mb_nls_get_default_detect_order_list(enum mbfl_no_language lang, enum mbfl_no_encoding **plist, size_t *plist_size)
547548
{
@@ -3678,6 +3679,7 @@ static uint32_t *make_conversion_map(HashTable *target_hash, size_t *conversion_
36783679
uint32_t *mapelm = convmap;
36793680

36803681
ZEND_HASH_FOREACH_VAL(target_hash, hash_entry) {
3682+
// TODO Check for entry values to be true int?
36813683
*mapelm++ = zval_get_long(hash_entry);
36823684
} ZEND_HASH_FOREACH_END();
36833685

0 commit comments

Comments
 (0)