Nits + better illegal string offset message

Author: Girgias

Zend/tests/bug24773.phpt

@@ -6,7 +6,7 @@ Bug #24773 (unset() of integers treated as arrays causes a crash)
     unset($array["lvl1"]["lvl2"]["b"]);
 ?>
 --EXPECTF--
-Fatal error: Uncaught TypeError: Illegal offset type in %s:%d
+Fatal error: Uncaught TypeError: Cannot access offset of type string on string in %s:%d
 Stack trace:
 #0 {main}
   thrown in %s on line %d

Zend/tests/bug31098.phpt

@@ -58,7 +58,7 @@ ok
 
 Warning: Attempt to read property "wrong" on string in %s on line %d
 ok
-Illegal offset type
+Cannot access offset of type string on string
 ok
-Illegal offset type
+Cannot access offset of type string on string
 ok

Zend/tests/bug53432.phpt

@@ -57,7 +57,7 @@ string(6) "     a"
 Warning: Illegal string offset -1 in %s on line %d
 NULL
 string(0) ""
-Illegal offset type
+Cannot access offset of type string on string
 string(1) "a"
 Error: [] operator not supported for strings
 string(0) ""

Zend/tests/indexing_001.phpt

@@ -76,11 +76,11 @@ array(1) {
 }
 
 Warning: Array to string conversion in %s on line %d
-Illegal offset type
+Cannot access offset of type string on string
 string(0) ""
 
 Warning: Array to string conversion in %s on line %d
-Illegal offset type
+Cannot access offset of type string on string
 string(1) " "
 Cannot use a scalar value as an array
 float(0.1)

Zend/tests/numeric_strings/string_offset.phpt

@@ -39,29 +39,29 @@ echo "Done\n";
 ?>
 --EXPECTF--
 string(1) "l"
-Illegal offset type
+Cannot access offset of type string on string
 string(1) "l"
-Illegal offset type
+Cannot access offset of type string on string
 string(1) "l"
-Illegal offset type
+Cannot access offset of type string on string
 string(1) "l"
-Illegal offset type
+Cannot access offset of type string on string
 
 Warning: Illegal string offset "7str" in %s on line %d
 string(1) "l"
-Illegal offset type
+Cannot access offset of type string on string
 
 Warning: Illegal string offset "  7str" in %s on line %d
 string(1) "l"
-Illegal offset type
+Cannot access offset of type string on string
 
 Warning: Illegal string offset "  7  str" in %s on line %d
 string(1) "l"
-Illegal offset type
+Cannot access offset of type string on string
 
 Warning: Illegal string offset "7  str" in %s on line %d
 string(1) "l"
-Illegal offset type
+Cannot access offset of type string on string
 
 Warning: Illegal string offset "0xC" in %s on line %d
 string(1) "T"

Zend/tests/offset_string.phpt

@@ -55,9 +55,9 @@ string(1) "S"
 
 Warning: String offset cast occurred in %s on line %d
 string(1) "S"
-Illegal offset type
+Cannot access offset of type string on string
 string(1) "c"
-Illegal offset type
+Cannot access offset of type string on string
 
 Warning: Illegal string offset "15 and then some" in %s on line %d
 string(1) "r"
@@ -67,9 +67,9 @@ string(1) "i"
 
 Warning: String offset cast occurred in %s on line %d
 string(1) "S"
-Illegal offset type
+Cannot access offset of type resource on string
 
 Notice: Object of class stdClass could not be converted to int in %s on line %d
-Illegal offset type
-Illegal offset type
+Cannot access offset of type stdClass on string
+Cannot access offset of type array on string
 Done