Add initial support for clone with

Author: kocsismate

Zend/tests/clone_initializer/clone_initializer_error1.phpt

@@ -0,0 +1,16 @@
+--TEST--
+Test that the property initializer list is required when "with" is given
+--FILE--
+<?php
+
+class Foo
+{
+    public function withProperties()
+    {
+        return clone $this with;
+    }
+}
+
+?>
+--EXPECTF--
+Parse error: syntax error, unexpected token ";", expecting "{" in %s on line %d

Zend/tests/clone_initializer/clone_initializer_error2.phpt

@@ -0,0 +1,16 @@
+--TEST--
+Test that the property initializer list cannot contain integer keys
+--FILE--
+<?php
+
+class Foo
+{
+    public function withProperties()
+    {
+        return clone $this with {1: "value"};
+    }
+}
+
+?>
+--EXPECTF--
+Parse error: syntax error, unexpected integer "1" in %s on line %d

Zend/tests/clone_initializer/clone_initializer_error3.phpt

@@ -0,0 +1,18 @@
+--TEST--
+Test that the property initializer list can only contain literals
+--FILE--
+<?php
+
+class Foo
+{
+    public function withProperties()
+    {
+        $property = "string";
+
+        return clone $this with {$property: "value"};
+    }
+}
+
+?>
+--EXPECTF--
+Parse error: syntax error, unexpected variable "$property" in %s on line %d

Zend/tests/clone_initializer/clone_initializer_error4.phpt

@@ -0,0 +1,21 @@
+--TEST--
+Test that the clone property initializer respects visibility
+--FILE--
+<?php
+
+class Foo
+{
+    private $bar;
+}
+
+$foo = new Foo();
+
+try {
+    $foo = clone $foo with {bar: 1};
+} catch (Error $exception) {
+    echo $exception->getMessage() . "\n";
+}
+
+?>
+--EXPECT--
+Cannot access private property Foo::$bar

Zend/tests/clone_initializer/clone_initializer_error5.phpt

@@ -0,0 +1,23 @@
+--TEST--
+Test that the "clone with" initializer list cannot contain the same property twice
+--FILE--
+<?php
+
+class Foo
+{
+    public function __construct(
+        public readonly int $bar
+    ) {}
+
+    public function with(int $bar, stdClass $baz)
+    {
+        return clone $this with {
+            bar: 1,
+            bar: 2,
+        };
+    }
+}
+
+?>
+--EXPECTF--
+Fatal error: Initializer list cannot contain the same property twice in %s on line %d

Zend/tests/clone_initializer/clone_initializer_success1.phpt

@@ -0,0 +1,38 @@
+--TEST--
+Test that declared properties can be initialized during cloning
+--FILE--
+<?php
+
+class Foo
+{
+    public int $property1;
+    public string $property2;
+
+    public function withProperties()
+    {
+        return clone $this with {
+            property1: 1,
+            property2: "foo",
+        };
+    }
+}
+
+$foo = new Foo();
+var_dump($foo);
+$bar = $foo->withProperties();
+var_dump($bar);
+
+?>
+--EXPECTF--
+object(Foo)#1 (%d) {
+  ["property1"]=>
+  uninitialized(int)
+  ["property2"]=>
+  uninitialized(string)
+}
+object(Foo)#2 (%d) {
+  ["property1"]=>
+  int(1)
+  ["property2"]=>
+  string(3) "foo"
+}

Zend/tests/clone_initializer/clone_initializer_success2.phpt

@@ -0,0 +1,41 @@
+--TEST--
+Test that dynamic properties can be initialized during cloning
+--FILE--
+<?php
+
+class Foo
+{
+    public function withProperties()
+    {
+        return clone $this with {
+            property1: 1,
+            property2: "foo",
+        };
+    }
+}
+
+$foo = new Foo();
+var_dump($foo);
+
+try {
+    $bar = $foo->withProperties();
+} catch (Exception $e) {
+    echo $e->getMessage() . "\n";
+}
+
+var_dump($bar);
+
+?>
+--EXPECTF--
+object(Foo)#1 (0) {
+}
+
+Deprecated: Creation of dynamic property Foo::$property1 is deprecated in %s on line %d
+
+Deprecated: Creation of dynamic property Foo::$property2 is deprecated in %s on line %d
+object(Foo)#2 (2) {
+  ["property1"]=>
+  int(1)
+  ["property2"]=>
+  string(3) "foo"
+}

Zend/tests/clone_initializer/clone_initializer_success3.phpt

@@ -0,0 +1,24 @@
+--TEST--
+Test that the property initializer list can be empty
+--FILE--
+<?php
+
+class Foo
+{
+    public function withProperties()
+    {
+        return clone $this with {};
+    }
+}
+
+$foo = new Foo();
+var_dump($foo);
+$bar = $foo->withProperties();
+var_dump($bar);
+
+?>
+--EXPECT--
+object(Foo)#1 (0) {
+}
+object(Foo)#2 (0) {
+}

Zend/tests/clone_initializer/clone_initializer_success4.phpt

@@ -0,0 +1,27 @@
+--TEST--
+Test that "clone with" is still chainable
+--FILE--
+<?php
+
+class Foo
+{
+    public $bar = 1;
+
+    public function withProperties()
+    {
+        return (clone $this with {})->bar;
+    }
+}
+
+$foo = new Foo();
+var_dump($foo);
+$bar = $foo->withProperties();
+var_dump($bar);
+
+?>
+--EXPECT--
+object(Foo)#1 (1) {
+  ["bar"]=>
+  int(1)
+}
+int(1)

Zend/tests/clone_initializer/clone_initializer_success5.phpt

@@ -0,0 +1,24 @@
+--TEST--
+Test that the "clone with" works with dynamic properties
+--FILE--
+<?php
+
+class Foo
+{
+}
+
+$foo = new Foo();
+$foo = clone $foo with {bar: 1, baz: ""};
+var_dump($foo);
+
+?>
+--EXPECTF--
+Deprecated: Creation of dynamic property Foo::$bar is deprecated in %s on line %d
+
+Deprecated: Creation of dynamic property Foo::$baz is deprecated in %s on line %d
+object(Foo)#2 (%d) {
+  ["bar"]=>
+  int(1)
+  ["baz"]=>
+  string(0) ""
+}

Zend/tests/clone_initializer/clone_initializer_success6.phpt

@@ -0,0 +1,24 @@
+--TEST--
+Test that "clone with" works with expressions as property values
+--FILE--
+<?php
+
+class Foo
+{
+    public $bar;
+    public $baz;
+}
+
+$foo = new Foo();
+$foo = clone $foo with {bar: new stdClass(), baz: strpos("abc", "b")};
+var_dump($foo);
+
+?>
+--EXPECT--
+object(Foo)#2 (2) {
+  ["bar"]=>
+  object(stdClass)#3 (0) {
+  }
+  ["baz"]=>
+  int(1)
+}

Zend/tests/clone_initializer/clone_initializer_success7.phpt

@@ -0,0 +1,20 @@
+--TEST--
+Test that "clone with" works with expressions as clone operand
+--FILE--
+<?php
+
+class Foo
+{
+    public static function create()
+    {
+        return new Foo();
+    }
+}
+
+$foo = clone Foo::create() with {};
+var_dump($foo);
+
+?>
+--EXPECT--
+object(Foo)#2 (0) {
+}

Zend/tests/clone_initializer/clone_initializer_success8.phpt

@@ -0,0 +1,44 @@
+--TEST--
+Test that "clone with" works with readonly properties
+--FILE--
+<?php
+
+class Foo
+{
+    public function __construct(
+        public readonly int $bar,
+        public readonly stdClass $baz,
+    ) {}
+
+    public function with(int $bar, stdClass $baz)
+    {
+        return clone $this with {
+            bar: 1,
+            baz: new stdClass(),
+        };
+    }
+}
+
+$stdClass = new stdClass();
+
+$foo = new Foo(0, $stdClass);
+var_dump($foo);
+
+var_dump($foo->with(1, $stdClass));
+
+?>
+--EXPECTF--
+object(Foo)#%d (%d) {
+  ["bar"]=>
+  int(0)
+  ["baz"]=>
+  object(stdClass)#%d (%d) {
+  }
+}
+object(Foo)#%d (%d) {
+  ["bar"]=>
+  int(1)
+  ["baz"]=>
+  object(stdClass)#%d (%d) {
+  }
+}

Zend/tests/readonly_props/readonly_clone_error1.phpt

@@ -10,9 +10,9 @@ class Foo {
 
     public function __clone()
     {
-        $this->bar++;
+        $this->bar = 2;
         var_dump($this);
-        $this->bar++;
+        $this->bar = 3;
     }
 }
 
@@ -24,10 +24,13 @@ try {
     echo $exception->getMessage() . "\n";
 }
 
+echo "done";
+
 ?>
 --EXPECT--
 object(Foo)#2 (1) {
   ["bar"]=>
   int(2)
 }
 Cannot modify readonly property Foo::$bar
+done

Zend/zend_ast.c

@@ -1842,6 +1842,11 @@ static ZEND_COLD void zend_ast_export_ex(smart_str *str, zend_ast *ast, int prio
 		case ZEND_AST_MATCH_ARM_LIST:
 			zend_ast_export_list(str, (zend_ast_list*)ast, 0, 0, indent);
 			break;
+		case ZEND_AST_PROPERTY_INITIALIZER_LIST:
+			smart_str_appends(str, " {");
+			zend_ast_export_list(str, (zend_ast_list*)ast, 0, 0, indent);
+			smart_str_appends(str, " }");
+			break;
 		case ZEND_AST_CLOSURE_USES:
 			smart_str_appends(str, " use(");
 			zend_ast_export_var_list(str, (zend_ast_list*)ast, indent);