Just return after throwing a ValueError

cmb69 · cmb69 · commit a601d519aa5a · 2019-09-30T16:40:56.000+02:00
diff --git a/ext/gd/gd.c b/ext/gd/gd.c
@@ -3147,7 +3147,7 @@ PHP_FUNCTION(imagecopyresized)
 
 	if (dstW <= 0 || dstH <= 0 || srcW <= 0 || srcH <= 0) {
 		zend_value_error("Invalid image dimensions");
-		RETURN_FALSE;
+		return;
 	}
 
 	gdImageCopyResized(im_dst, im_src, dstX, dstY, srcX, srcY, dstW, dstH, srcW, srcH);
@@ -3689,7 +3689,7 @@ PHP_FUNCTION(imageflip)
 
 		default:
 			zend_value_error("Unknown flip mode");
-			RETURN_FALSE;
+			return;
 	}
 
 	RETURN_TRUE;

Original file line number	Diff line number	Diff line change
`@@ -3147,7 +3147,7 @@ PHP_FUNCTION(imagecopyresized)`
`3147`	`3147`
`3148`	`3148`	`if (dstW <= 0 \|\| dstH <= 0 \|\| srcW <= 0 \|\| srcH <= 0) {`
`3149`	`3149`	`zend_value_error("Invalid image dimensions");`
`3150`		`- RETURN_FALSE;`
	`3150`	`+ return;`
`3151`	`3151`	`}`
`3152`	`3152`
`3153`	`3153`	`gdImageCopyResized(im_dst, im_src, dstX, dstY, srcX, srcY, dstW, dstH, srcW, srcH);`
`@@ -3689,7 +3689,7 @@ PHP_FUNCTION(imageflip)`
`3689`	`3689`
`3690`	`3690`	`default:`
`3691`	`3691`	`zend_value_error("Unknown flip mode");`
`3692`		`- RETURN_FALSE;`
	`3692`	`+ return;`
`3693`	`3693`	`}`
`3694`	`3694`
`3695`	`3695`	`RETURN_TRUE;`