Skip to content

Commit a5f27fd

Browse files
committed
Merge branch 'PHP-8.2'
2 parents 6a08893 + 2b71fa6 commit a5f27fd

File tree

3 files changed

+17
-10
lines changed

3 files changed

+17
-10
lines changed

sapi/fpm/fpm/fpm.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ struct fpm_globals_s fpm_globals = {
4141
.send_config_pipe = {0, 0},
4242
};
4343

44-
int fpm_init(int argc, char **argv, char *config, char *prefix, char *pid, int test_conf, int run_as_root, int force_daemon, int force_stderr) /* {{{ */
44+
enum fpm_init_return_status fpm_init(int argc, char **argv, char *config, char *prefix, char *pid, int test_conf, int run_as_root, int force_daemon, int force_stderr) /* {{{ */
4545
{
4646
fpm_globals.argc = argc;
4747
fpm_globals.argv = argv;
@@ -67,22 +67,22 @@ int fpm_init(int argc, char **argv, char *config, char *prefix, char *pid, int t
6767
0 > fpm_event_init_main()) {
6868

6969
if (fpm_globals.test_successful) {
70-
exit(FPM_EXIT_OK);
70+
return FPM_INIT_EXIT_OK;
7171
} else {
7272
zlog(ZLOG_ERROR, "FPM initialization failed");
73-
return -1;
73+
return FPM_INIT_ERROR;
7474
}
7575
}
7676

7777
if (0 > fpm_conf_write_pid()) {
7878
zlog(ZLOG_ERROR, "FPM initialization failed");
79-
return -1;
79+
return FPM_INIT_ERROR;
8080
}
8181

8282
fpm_stdio_init_final();
8383
zlog(ZLOG_NOTICE, "fpm is running, pid %d", (int) fpm_globals.parent_pid);
8484

85-
return 0;
85+
return FPM_INIT_CONTINUE;
8686
}
8787
/* }}} */
8888

sapi/fpm/fpm/fpm.h

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,14 @@
3434
#endif
3535

3636

37+
enum fpm_init_return_status {
38+
FPM_INIT_ERROR,
39+
FPM_INIT_CONTINUE,
40+
FPM_INIT_EXIT_OK,
41+
};
42+
3743
int fpm_run(int *max_requests);
38-
int fpm_init(int argc, char **argv, char *config, char *prefix, char *pid, int test_conf, int run_as_root, int force_daemon, int force_stderr);
44+
enum fpm_init_return_status fpm_init(int argc, char **argv, char *config, char *prefix, char *pid, int test_conf, int run_as_root, int force_daemon, int force_stderr);
3945

4046
struct fpm_globals_s {
4147
pid_t parent_pid;

sapi/fpm/fpm/fpm_main.c

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1537,7 +1537,6 @@ int main(int argc, char *argv[])
15371537
int force_stderr = 0;
15381538
int php_information = 0;
15391539
int php_allow_to_run_as_root = 0;
1540-
int ret;
15411540
#if ZEND_RC_DEBUG
15421541
bool old_rc_debug;
15431542
#endif
@@ -1784,14 +1783,13 @@ consult the installation file that came with this distribution, or visit \n\
17841783
zend_rc_debug = 0;
17851784
#endif
17861785

1787-
ret = fpm_init(argc, argv, fpm_config ? fpm_config : CGIG(fpm_config), fpm_prefix, fpm_pid, test_conf, php_allow_to_run_as_root, force_daemon, force_stderr);
1786+
enum fpm_init_return_status ret = fpm_init(argc, argv, fpm_config ? fpm_config : CGIG(fpm_config), fpm_prefix, fpm_pid, test_conf, php_allow_to_run_as_root, force_daemon, force_stderr);
17881787

17891788
#if ZEND_RC_DEBUG
17901789
zend_rc_debug = old_rc_debug;
17911790
#endif
17921791

1793-
if (ret < 0) {
1794-
1792+
if (ret == FPM_INIT_ERROR) {
17951793
if (fpm_globals.send_config_pipe[1]) {
17961794
int writeval = 0;
17971795
zlog(ZLOG_DEBUG, "Sending \"0\" (error) to parent via fd=%d", fpm_globals.send_config_pipe[1]);
@@ -1800,6 +1798,9 @@ consult the installation file that came with this distribution, or visit \n\
18001798
}
18011799
exit_status = FPM_EXIT_CONFIG;
18021800
goto out;
1801+
} else if (ret == FPM_INIT_EXIT_OK) {
1802+
exit_status = FPM_EXIT_OK;
1803+
goto out;
18031804
}
18041805

18051806
if (fpm_globals.send_config_pipe[1]) {

0 commit comments

Comments
 (0)