Skip to content

Commit a5bfad6

Browse files
committed
Check sessions are active before output emitted consistently
1 parent 6e51551 commit a5bfad6

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

ext/session/session.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -741,8 +741,8 @@ static PHP_INI_MH(OnUpdateSessionStr) /* {{{ */
741741

742742
static PHP_INI_MH(OnUpdateSessionBool) /* {{{ */
743743
{
744-
SESSION_CHECK_OUTPUT_STATE;
745744
SESSION_CHECK_ACTIVE_STATE;
745+
SESSION_CHECK_OUTPUT_STATE;
746746
return OnUpdateBool(entry, new_value, mh_arg1, mh_arg2, mh_arg3, stage);
747747
}
748748
/* }}} */
@@ -753,8 +753,8 @@ static PHP_INI_MH(OnUpdateSidLength) /* {{{ */
753753
zend_long val;
754754
char *endptr = NULL;
755755

756-
SESSION_CHECK_OUTPUT_STATE;
757756
SESSION_CHECK_ACTIVE_STATE;
757+
SESSION_CHECK_OUTPUT_STATE;
758758
val = ZEND_STRTOL(ZSTR_VAL(new_value), &endptr, 10);
759759
if (endptr && (*endptr == '\0')
760760
&& val >= 22 && val <= PS_MAX_SID_LENGTH) {
@@ -773,8 +773,8 @@ static PHP_INI_MH(OnUpdateSidBits) /* {{{ */
773773
zend_long val;
774774
char *endptr = NULL;
775775

776-
SESSION_CHECK_OUTPUT_STATE;
777776
SESSION_CHECK_ACTIVE_STATE;
777+
SESSION_CHECK_OUTPUT_STATE;
778778
val = ZEND_STRTOL(ZSTR_VAL(new_value), &endptr, 10);
779779
if (endptr && (*endptr == '\0')
780780
&& val >= 4 && val <=6) {

0 commit comments

Comments
 (0)