Skip to content

Commit a5755c1

Browse files
committed
Undeprecate the constants
1 parent 533bf6d commit a5755c1

File tree

4 files changed

+7
-18
lines changed

4 files changed

+7
-18
lines changed

NEWS

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,8 @@ DOM:
1212

1313
Intl:
1414
. Added IntlDateFormatter::PATTERN constant. (David Carlier)
15-
. Deprecated constants ROUND_DOWN and ROUND_UP for the consistency with new
16-
rounding modes. Added instead aliases ROUND_TOWARD_ZERO and
17-
ROUND_AWAY_FROM_ZERO. (Jorg Sowa)
15+
. Created aliases ROUND_TOWARD_ZERO and ROUND_AWAY_FROM_ZERO for constants
16+
ROUND_DOWN and ROUND_UP. (Jorg Sowa)
1817

1918
SimpleXML:
2019
. Fixed bug GH-12192 (SimpleXML infinite loop when getName() is called

ext/intl/formatter/formatter.stub.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,13 +84,11 @@ class NumberFormatter
8484
public const ROUND_FLOOR = UNKNOWN;
8585
/**
8686
* @var int
87-
* @deprecated
8887
* @cvalue UNUM_ROUND_DOWN
8988
*/
9089
public const ROUND_DOWN = UNKNOWN;
9190
/**
9291
* @var int
93-
* @deprecated
9492
* @cvalue UNUM_ROUND_UP
9593
*/
9694
public const ROUND_UP = UNKNOWN;

ext/intl/formatter/formatter_arginfo.h

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

ext/intl/tests/formatter/rounding_modes.phpt

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
--TEST--
2-
IntlBreakIterator: clone handler
2+
NumberFormatter: rounding modes
33
--EXTENSIONS--
44
intl
55
--FILE--
@@ -22,20 +22,12 @@ var_dump(NumberFormatter::ROUND_UP === NumberFormatter::ROUND_AWAY_FROM_ZERO);
2222
--EXPECTF--
2323
int(0)
2424
int(1)
25-
26-
Deprecated: Constant NumberFormatter::ROUND_DOWN is deprecated in %s
2725
int(2)
2826
int(2)
29-
30-
Deprecated: Constant NumberFormatter::ROUND_UP is deprecated in %s
3127
int(3)
3228
int(3)
3329
int(4)
3430
int(5)
3531
int(6)
36-
37-
Deprecated: Constant NumberFormatter::ROUND_DOWN is deprecated in %s
3832
bool(true)
39-
40-
Deprecated: Constant NumberFormatter::ROUND_UP is deprecated in %s
41-
bool(true)
33+
bool(true)

0 commit comments

Comments
 (0)