Update OOM error for DOMImplementation::createDocumentType (#14329)

nielsdos · web-flow · commit a356d1c0e968 · 2024-05-26T17:31:27.000+02:00
Most of these kinds of error handling were already changed previously,
but this one was apparently missed.
diff --git a/ext/dom/domimplementation.c b/ext/dom/domimplementation.c
@@ -100,8 +100,8 @@ PHP_METHOD(DOMImplementation, createDocumentType)
 	xmlFree(localname);
 
 	if (doctype == NULL) {
-		php_error_docref(NULL, E_WARNING, "Unable to create DocumentType");
-		RETURN_FALSE;
+		php_dom_throw_error(INVALID_STATE_ERR, /* strict */ true);
+		RETURN_THROWS();
 	}
 
 	DOM_RET_OBJ((xmlNodePtr) doctype, NULL);

Original file line number	Diff line number	Diff line change
`@@ -100,8 +100,8 @@ PHP_METHOD(DOMImplementation, createDocumentType)`
`100`	`100`	`xmlFree(localname);`
`101`	`101`
`102`	`102`	`if (doctype == NULL) {`
`103`		`- php_error_docref(NULL, E_WARNING, "Unable to create DocumentType");`
`104`		`- RETURN_FALSE;`
	`103`	`+ php_dom_throw_error(INVALID_STATE_ERR, /* strict */ true);`
	`104`	`+ RETURN_THROWS();`
`105`	`105`	`}`
`106`	`106`
`107`	`107`	`DOM_RET_OBJ((xmlNodePtr) doctype, NULL);`