Skip to content

Commit a2bfcc3

Browse files
committed
[skip ci] Remove TODOs
1 parent 1dfc39d commit a2bfcc3

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

ext/phar/tar.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,6 @@ static int phar_tar_process_metadata(phar_entry_info *entry, php_stream *fp) /*
173173
return FAILURE;
174174
}
175175

176-
/* TODO: Stop relying on the undef check for checking for duplicate metadata */
177176
phar_parse_metadata_lazy(metadata, &entry->metadata_tracker, entry->uncompressed_filesize, entry->is_persistent);
178177

179178
if (entry->filename_len == sizeof(".phar/.metadata.bin")-1 && !memcmp(entry->filename, ".phar/.metadata.bin", sizeof(".phar/.metadata.bin")-1)) {

ext/phar/util.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1971,7 +1971,7 @@ static int phar_update_cached_entry(zval *data, void *argument) /* {{{ */
19711971
entry->filename = estrndup(entry->filename, entry->filename_len);
19721972
entry->is_persistent = 0;
19731973

1974-
/* TODO: Is it necessary to replace persistent strings with non-persistent? */
1974+
/* Replace metadata with non-persistent clones of the metadata. */
19751975
phar_metadata_tracker_clone(&entry->metadata_tracker);
19761976
return ZEND_HASH_APPLY_KEEP;
19771977
}

0 commit comments

Comments
 (0)