Fix #81424: PCRE2 10.35 JIT performance regression

cmb69 · cmb69 · commit a2471383fec3 · 2021-09-13T14:34:13.000+02:00
We backport the respective upstream fix[1] to our bundled pcre2lib. [1] <PCRE2Project/pcre2@dc5f966> Closes GH-7484.
diff --git a/NEWS b/NEWS
@@ -6,6 +6,9 @@ PHP                                                                        NEWS
   . Fixed bug #81433 (DOMElement::setIdAttribute() called twice may remove ID).
     (Viktor Volkov)
 
+- PCRE:
+  . Fixed bug #81424 (PCRE2 10.35 JIT performance regression). (cmb)
+
 23 Dep 2021, PHP 7.4.24
 
 - Core:
diff --git a/ext/pcre/pcre2lib/pcre2_jit_compile.c b/ext/pcre/pcre2lib/pcre2_jit_compile.c
@@ -11152,7 +11152,7 @@ early_fail_type = (early_fail_ptr & 0x7);
 early_fail_ptr >>= 3;
 
 /* During recursion, these optimizations are disabled. */
-if (common->early_fail_start_ptr == 0)
+if (common->early_fail_start_ptr == 0 && common->fast_forward_bc_ptr == NULL)
   {
   early_fail_ptr = 0;
   early_fail_type = type_skip;

Original file line number	Diff line number	Diff line change
`@@ -11152,7 +11152,7 @@ early_fail_type = (early_fail_ptr & 0x7);`
`11152`	`11152`	`early_fail_ptr >>= 3;`
`11153`	`11153`
`11154`	`11154`	`/* During recursion, these optimizations are disabled. */`
`11155`		`-if (common->early_fail_start_ptr == 0)`
	`11155`	`+if (common->early_fail_start_ptr == 0 && common->fast_forward_bc_ptr == NULL)`
`11156`	`11156`	`{`
`11157`	`11157`	`early_fail_ptr = 0;`
`11158`	`11158`	`early_fail_type = type_skip;`