Merge branch 'PHP-8.4'

nielsdos · nielsdos · commit a1974e6db0ed · 2024-10-12T13:41:29.000+02:00
* PHP-8.4:
  Restore accidentally deleted check
diff --git a/ext/dom/node.c b/ext/dom/node.c
@@ -1152,6 +1152,10 @@ static void dom_node_replace_child(INTERNAL_FUNCTION_PARAMETERS, bool modern)
 			RETURN_FALSE;
 		}
 
+		if (!nodep->children) {
+			RETURN_FALSE;
+		}
+
 		if (!dom_node_check_legacy_insertion_validity(nodep, newchild, stricterror, false)) {
 			RETURN_FALSE;
 		}

Original file line number	Diff line number	Diff line change
`@@ -1152,6 +1152,10 @@ static void dom_node_replace_child(INTERNAL_FUNCTION_PARAMETERS, bool modern)`
`1152`	`1152`	`RETURN_FALSE;`
`1153`	`1153`	`}`
`1154`	`1154`
	`1155`	`+ if (!nodep->children) {`
	`1156`	`+ RETURN_FALSE;`
	`1157`	`+ }`
	`1158`	`+`
`1155`	`1159`	`if (!dom_node_check_legacy_insertion_validity(nodep, newchild, stricterror, false)) {`
`1156`	`1160`	`RETURN_FALSE;`
`1157`	`1161`	`}`