Skip to content

Commit 9fe4d2d

Browse files
committed
Merge branch 'PHP-7.0' into PHP-7.1
* PHP-7.0: Fix of Bug #74383: Wrong reflection on Phar::running
2 parents bb5535b + 775afd5 commit 9fe4d2d

File tree

3 files changed

+24
-1
lines changed

3 files changed

+24
-1
lines changed

NEWS

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,9 @@ PHP NEWS
3131
. Fixed bug #74341 (openssl_x509_parse fails to parse ASN.1 UTCTime without
3232
seconds). (Moritz Fain)
3333

34+
- phar:
35+
. Fixed bug #74383 phar method parameters reflection correction. (mhagstrand)
36+
3437
- Standard:
3538
. Fixed bug #72071 (setcookie allows max-age to be negative). (Craig Duncan)
3639
. Fixed bug #74361 (Compaction in array_rand() violates COW). (Nikita)

ext/phar/phar_object.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5134,7 +5134,7 @@ ZEND_BEGIN_ARG_INFO_EX(arginfo_phar_webPhar, 0, 0, 0)
51345134
ZEND_ARG_INFO(0, rewrites)
51355135
ZEND_END_ARG_INFO()
51365136

5137-
ZEND_BEGIN_ARG_INFO_EX(arginfo_phar_running, 0, 0, 1)
5137+
ZEND_BEGIN_ARG_INFO_EX(arginfo_phar_running, 0, 0, 0)
51385138
ZEND_ARG_INFO(0, retphar)
51395139
ZEND_END_ARG_INFO()
51405140

ext/phar/tests/bug74383.phpt

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
--TEST--
2+
Phar: bug #74383: Wrong reflection on Phar::running
3+
--SKIPIF--
4+
<?php if (!extension_loaded("phar") || !extension_loaded('reflection')) die("skip"); ?>
5+
--FILE--
6+
<?php
7+
$rc = new ReflectionClass(Phar::class);
8+
$rm = $rc->getMethod("running");
9+
echo $rm->getNumberOfParameters();
10+
echo PHP_EOL;
11+
echo $rm->getNumberOfRequiredParameters();
12+
echo PHP_EOL;
13+
echo (int) $rm->getParameters()[0]->isOptional();
14+
15+
?>
16+
17+
--EXPECT--
18+
1
19+
0
20+
1

0 commit comments

Comments
 (0)