Skip to content

Commit 9e56a33

Browse files
committed
Terminate smart string correctly
This is related to Zend VM regression bug #75881. The regression was fixed in the VM, so there is no user visible change from the termination correction.
1 parent 91954c2 commit 9e56a33

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

ext/oci8/oci8.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1788,12 +1788,12 @@ php_oci_connection *php_oci_do_connect_ex(char *username, int username_len, char
17881788
timestamp = time(NULL);
17891789

17901790
smart_str_append_unsigned_ex(&hashed_details, session_mode, 0);
1791-
smart_str_0(&hashed_details);
1792-
17931791
if (persistent) {
17941792
smart_str_appendl_ex(&hashed_details, "pc", sizeof("pc") - 1, 0);
17951793
}
17961794

1795+
smart_str_0(&hashed_details);
1796+
17971797
/* make it lowercase */
17981798
php_strtolower(ZSTR_VAL(hashed_details.s), ZSTR_LEN(hashed_details.s));
17991799

0 commit comments

Comments
 (0)