Skip to content

Commit 9a73ec0

Browse files
mvorisekcmb69
authored andcommitted
Always skip randomly failing OCI8 extauth tests
This might be caused by an issue with the Oracle Instant Client libraries[1]; we skip the tests for the time being. [1] <#9524 (comment)> Closes GH-9524.
1 parent 47500f3 commit 9a73ec0

File tree

4 files changed

+5
-12
lines changed

4 files changed

+5
-12
lines changed

ext/oci8/tests/extauth_01.phpt

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,16 +4,13 @@ Test External Authentication errors with oci_connect
44
<?php
55
if (!extension_loaded('oci8')) die ("skip no oci8 extension");
66
if (substr(PHP_OS, 0, 3) == 'WIN') die("skip feature not available on Windows platforms");
7-
require(__DIR__.'/details.inc');
8-
if (getenv('SKIP_SLOW_TESTS')) die('skip slow tests excluded by request');
7+
die("skip random CI timeouts caused by Oracle Instant Client, see https://github.com/php/php-src/pull/9524#issuecomment-1244409815");
98
?>
109
--INI--
1110
oci8.privileged_connect=1
1211
--FILE--
1312
<?php
1413

15-
// Run Test
16-
1714
echo "Test 1\n";
1815

1916
$c = oci_connect('/', 'notemtpy', 'anything', null, OCI_CRED_EXT);

ext/oci8/tests/extauth_02.phpt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,16 +3,14 @@ Test External Authentication errors with oci_new_connect
33
--SKIPIF--
44
<?php
55
if (!extension_loaded('oci8')) die ("skip no oci8 extension");
6-
if (getenv('SKIP_SLOW_TESTS')) die('skip slow tests excluded by request');
76
if (substr(PHP_OS, 0, 3) == 'WIN') die("skip feature not available on Windows platforms");
7+
die("skip random CI timeouts caused by Oracle Instant Client, see https://github.com/php/php-src/pull/9524#issuecomment-1244409815");
88
?>
99
--INI--
1010
oci8.privileged_connect=1
1111
--FILE--
1212
<?php
1313

14-
// Run Test
15-
1614
echo "Test 1\n";
1715

1816
$c = oci_new_connect('/', 'notemtpy', 'anything', null, OCI_CRED_EXT);

ext/oci8/tests/extauth_03.phpt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,16 +3,14 @@ Test External Authentication errors with oci_pconnect
33
--SKIPIF--
44
<?php
55
if (!extension_loaded('oci8')) die ("skip no oci8 extension");
6-
if (getenv('SKIP_SLOW_TESTS')) die('skip slow tests excluded by request');
76
if (substr(PHP_OS, 0, 3) == 'WIN') die("skip feature not available on Windows platforms");
7+
die("skip random CI timeouts caused by Oracle Instant Client, see https://github.com/php/php-src/pull/9524#issuecomment-1244409815");
88
?>
99
--INI--
1010
oci8.privileged_connect=1
1111
--FILE--
1212
<?php
1313

14-
// Run Test
15-
1614
echo "Test 1\n";
1715

1816
$c = oci_pconnect('/', 'notemtpy', 'anything', null, OCI_CRED_EXT);

ext/oci8/tests/extauth_04.phpt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,11 @@ Test External Authentication errors on Windows
55
if (!extension_loaded('oci8')) die ("skip no oci8 extension");
66
if (substr(PHP_OS, 0, 3) != 'WIN') die("skip this test is for Windows platforms only");
77
?>
8+
--INI--
9+
oci8.privileged_connect=1
810
--FILE--
911
<?php
1012

11-
// Run Test
12-
1313
echo "Test 1\n";
1414

1515
$c = oci_connect('/', '', 'anything', null, OCI_CRED_EXT);

0 commit comments

Comments
 (0)