size variable is only used once, move closer to usage

Girgias · Girgias · commit 96ffdd492c5a · 2023-04-06T14:56:42.000+01:00
Also change type to ssize_t as this is what the function returns
diff --git a/ext/phar/func_interceptors.c b/ext/phar/func_interceptors.c
@@ -230,7 +230,6 @@ PHAR_FUNC(phar_file_get_contents) /* {{{ */
 PHAR_FUNC(phar_readfile) /* {{{ */
 {
 	zend_string *filename;
-	int size = 0;
 	bool use_include_path = 0;
 	zval *zcontext = NULL;
 	php_stream *stream;
@@ -259,7 +258,7 @@ PHAR_FUNC(phar_readfile) /* {{{ */
 		if (stream == NULL) {
 			RETURN_FALSE;
 		}
-		size = php_stream_passthru(stream);
+		ssize_t size = php_stream_passthru(stream);
 		php_stream_close(stream);
 		RETURN_LONG(size);
 	}

Original file line number	Diff line number	Diff line change
`@@ -230,7 +230,6 @@ PHAR_FUNC(phar_file_get_contents) /* {{{ */`
`230`	`230`	`PHAR_FUNC(phar_readfile) /* {{{ */`
`231`	`231`	`{`
`232`	`232`	`zend_string *filename;`
`233`		`- int size = 0;`
`234`	`233`	`bool use_include_path = 0;`
`235`	`234`	`zval *zcontext = NULL;`
`236`	`235`	`php_stream *stream;`
`@@ -259,7 +258,7 @@ PHAR_FUNC(phar_readfile) /* {{{ */`
`259`	`258`	`if (stream == NULL) {`
`260`	`259`	`RETURN_FALSE;`
`261`	`260`	`}`
`262`		`- size = php_stream_passthru(stream);`
	`261`	`+ ssize_t size = php_stream_passthru(stream);`
`263`	`262`	`php_stream_close(stream);`
`264`	`263`	`RETURN_LONG(size);`
`265`	`264`	`}`