Do not return true in case of the constructor

kocsismate · kocsismate · commit 96f34480805f · 2021-05-26T12:16:09.000+02:00
diff --git a/UPGRADING b/UPGRADING
@@ -100,6 +100,7 @@ PHP 8.1 UPGRADE NOTES
   . Classes extending mysqli_stmt::execute() will be required to specify the
     additional parameter now.
     RFC: https://wiki.php.net/rfc/mysqli_bind_in_execute
+  . mysqli::connect() will now return true instead of null on success.
 
 - MySQLnd:
   . The mysqlnd.fetch_copy_data ini setting has been removed. However, this
diff --git a/ext/mysqli/mysqli_nonapi.c b/ext/mysqli/mysqli_nonapi.c
@@ -362,7 +362,9 @@ void mysqli_common_connect(INTERNAL_FUNCTION_PARAMETERS, bool is_real_connect, b
 		(Z_MYSQLI_P(object))->ptr = mysqli_resource;
 	}
 
-	RETURN_TRUE;
+	if (!in_ctor) {
+		RETURN_TRUE;
+	}
 
 err:
 	if (mysql->hash_key) {

Original file line number	Diff line number	Diff line change
`@@ -362,7 +362,9 @@ void mysqli_common_connect(INTERNAL_FUNCTION_PARAMETERS, bool is_real_connect, b`
`362`	`362`	`(Z_MYSQLI_P(object))->ptr = mysqli_resource;`
`363`	`363`	`}`
`364`	`364`
`365`		`- RETURN_TRUE;`
	`365`	`+ if (!in_ctor) {`
	`366`	`+ RETURN_TRUE;`
	`367`	`+ }`
`366`	`368`
`367`	`369`	`err:`
`368`	`370`	`if (mysql->hash_key) {`