Fix Bug #81588 TokyoCabinet driver leaks memory

Girgias · Girgias · commit 96dd310c5458 · 2021-11-03T14:57:47.000Z
diff --git a/NEWS b/NEWS
@@ -12,6 +12,9 @@ PHP                                                                        NEWS
   . Fixed bug #81500 (Interval serialization regression since 7.3.14 / 7.4.2).
     (cmb)
 
+- DBA:
+  . Fixed bug #81588 (TokyoCabinet driver leaks memory). (girgias)
+
 - MBString:
   . Fixed bug #76167 (mbstring may use pointer from some previous request).
     (cmb, cataphract)
diff --git a/ext/dba/dba_tcadb.c b/ext/dba/dba_tcadb.c
@@ -81,6 +81,7 @@ DBA_CLOSE_FUNC(tcadb)
 	TCADB_DATA;
 
 	tcadbclose(dba->tcadb);
+	tcadbdel(dba->tcadb);
 	pefree(dba, info->flags & DBA_PERSISTENT);
 }
 
diff --git a/ext/dba/tests/dba_tcadb.phpt b/ext/dba/tests/dba_tcadb.phpt
@@ -7,6 +7,7 @@ DBA TCADB handler test
 ?>
 --FILE--
 <?php
+    $handler = 'tcadb';
     $lock_flag = 'l';
     $db_filename = $db_file = __DIR__ .'/test0.tch';
     @unlink($db_filename);

Original file line number	Diff line number	Diff line change
`@@ -81,6 +81,7 @@ DBA_CLOSE_FUNC(tcadb)`
`81`	`81`	`TCADB_DATA;`
`82`	`82`
`83`	`83`	`tcadbclose(dba->tcadb);`
	`84`	`+ tcadbdel(dba->tcadb);`
`84`	`85`	`pefree(dba, info->flags & DBA_PERSISTENT);`
`85`	`86`	`}`
`86`	`87`