Deprecate passing empty array to array_(sum|product)()

Author: Girgias

ext/standard/array.c

@@ -5913,7 +5913,7 @@ PHP_FUNCTION(array_sum)
 	ZEND_PARSE_PARAMETERS_END();
 
 	if (zend_hash_num_elements(input) == 0) {
-		// TODO Deprecate empty array
+		php_error_docref(NULL, E_DEPRECATED, "Passing an empty array is deprecated");
 		RETURN_LONG(0);
 	}
 
@@ -5963,7 +5963,7 @@ PHP_FUNCTION(array_product)
 	ZEND_PARSE_PARAMETERS_END();
 
 	if (zend_hash_num_elements(input) == 0) {
-		// TODO Deprecate empty array
+		php_error_docref(NULL, E_DEPRECATED, "Passing an empty array is deprecated");
 		RETURN_LONG(1);
 	}
 

ext/standard/tests/array/array_product_empty_array.phpt

@@ -0,0 +1,10 @@
+--TEST--
+Test array_product() function with empty array
+--FILE--
+<?php
+$input = [];
+var_dump(array_product($input));
+?>
+--EXPECTF--
+Deprecated: array_product(): Passing an empty array is deprecated in %s on line %d
+int(1)

ext/standard/tests/array/array_sum_empty_array.phpt

@@ -0,0 +1,10 @@
+--TEST--
+Test array_sum() function with empty array
+--FILE--
+<?php
+$input = [];
+var_dump(array_sum($input));
+?>
+--EXPECTF--
+Deprecated: array_sum(): Passing an empty array is deprecated in %s on line %d
+int(0)

ext/standard/tests/array/array_sum_variation7.phpt

@@ -9,11 +9,6 @@ Test array_sum() function : usage variations - 'input' array with unexpected val
 
 echo "*** Testing array_sum() : array with unexpected entries ***\n";
 
-// empty array
-$input = array();
-echo "-- empty array --\n";
-var_dump( array_sum($input) );
-
 // string array
 $input = array('Apple', 'Banana', 'Carrot', 'Mango', 'Orange');
 echo "-- array with string values --\n";
@@ -64,8 +59,6 @@ echo "Done"
 ?>
 --EXPECT--
 *** Testing array_sum() : array with unexpected entries ***
--- empty array --
-int(0)
 -- array with string values --
 int(0)
 -- array with bool values --

ext/standard/tests/array/bug35014.phpt

@@ -5,7 +5,6 @@ Bug #35014 (array_product() always returns 0) (32bit)
 --FILE--
 <?php
 $tests = array(
-    array(),
     array(0),
     array(3),
     array(3, 3),
@@ -20,7 +19,6 @@ foreach ($tests as $v) {
 }
 ?>
 --EXPECT--
-int(1)
 int(0)
 int(3)
 int(9)

ext/standard/tests/array/bug35014_64bit.phpt

@@ -7,7 +7,6 @@ precision=14
 --FILE--
 <?php
 $tests = array(
-    array(),
     array(0),
     array(3),
     array(3, 3),
@@ -22,7 +21,6 @@ foreach ($tests as $v) {
 }
 ?>
 --EXPECT--
-int(1)
 int(0)
 int(3)
 int(9)