Renamed public reflection struct and method.

Added tests for anonymous classes, callables and closures.

Author: Bilge

Zend/tests/default_expression/anonymous_class.phpt

@@ -0,0 +1,18 @@
+--TEST--
+Tests passing default to anonymous class methods
+--FILE--
+<?php
+
+$C = new class {
+    function __invoke($V = 'Alfa') {}
+    function F($V = 'Bravo') {}
+};
+$C($D = default);
+var_dump($D);
+
+$C->F($D = default);
+var_dump($D);
+?>
+--EXPECT--
+string(4) "Alfa"
+string(5) "Bravo"

Zend/tests/default_expression/callable.phpt

@@ -0,0 +1,13 @@
+--TEST--
+Tests passing default to a callable object
+--FILE--
+<?php
+
+class C {
+    function __invoke($V = 'Alfa') {}
+}
+new C()($D = default);
+var_dump($D);
+?>
+--EXPECT--
+string(4) "Alfa"

Zend/tests/default_expression/closure.phpt

@@ -0,0 +1,20 @@
+--TEST--
+Tests passing default to closures
+--FILE--
+<?php
+
+$F = function ($X = 1, $Y = 2) {
+    return $X + $Y;
+};
+var_dump($F(default, $V = default));
+var_dump($V);
+
+$F2 = fn ($P = 'Alfa') => $P;
+var_dump($F2($V = default));
+var_dump($V);
+?>
+--EXPECT--
+int(3)
+int(2)
+string(4) "Alfa"
+string(4) "Alfa"

Zend/tests/default_expression/default_expressions.phpt

@@ -2,6 +2,7 @@
 Tests an exhaustive list of valid expressions containing the default keyword
 --FILE--
 <?php
+
 function F($V = 2) { return $V; }
 
 var_dump(F(default + 1));

Zend/tests/default_expression/multiple_arguments.phpt

@@ -1,5 +1,5 @@
 --TEST--
-Test passing multiple default arguments to global user function parameters
+Tests passing multiple default arguments to global user function parameters
 --FILE--
 <?php
 

Zend/tests/default_expression/nested_calls.phpt

@@ -1,10 +1,10 @@
 --TEST--
-Test passing default in a parent argument position that is less than the child call's total number of arguments
+Tests passing default in a parent argument position that is less than the child call's total number of arguments
 --FILE--
 <?php
 
-function F($x = 1, $y = 2) {
-	return $x + $y;
+function F($X = 1, $Y = 2) {
+	return $X + $Y;
 }
 var_dump(F(F(0, 1) + default));
 ?>

Zend/tests/default_expression/new_class_parameter.phpt

@@ -1,5 +1,5 @@
 --TEST--
-Test passing default to a parameter with a new class as the default
+Tests passing default to a parameter with a new class as the default
 --FILE--
 <?php
 

Zend/tests/default_expression/default_to_required_parameter_of_internal_class.phpt renamed to Zend/tests/default_expression/required_parameter_of_internal_class.phpt

@@ -9818,7 +9818,7 @@ ZEND_VM_HANDLER(210, ZEND_FETCH_DEFAULT_ARG, UNUSED|NUM, UNUSED)
 
 	zend_function *called_func = EX(call)->func;
 
-	parameter_reference param;
+	reflection_parameter_reference param;
 	param.offset = opline->op1.num - 1;
 	param.required = param.offset < called_func->common.required_num_args;
 	param.arg_info = &called_func->common.arg_info[param.offset];
@@ -9835,13 +9835,12 @@ ZEND_VM_HANDLER(210, ZEND_FETCH_DEFAULT_ARG, UNUSED|NUM, UNUSED)
 	}
 
 	zval default_value;
-	get_parameter_default(&default_value, &param);
+	reflection_get_parameter_default(&default_value, &param);
 
 	// Evaluate AST value, e.g. new class.
-	if (Z_TYPE(default_value) == IS_CONSTANT_AST) {
-		if (UNEXPECTED(zval_update_constant_ex(&default_value, called_func->common.scope) != SUCCESS)) {
+	if (Z_TYPE(default_value) == IS_CONSTANT_AST
+		&& UNEXPECTED(zval_update_constant_ex(&default_value, called_func->common.scope) != SUCCESS)) {
 			HANDLE_EXCEPTION();
-		}
 	}
 
 	ZVAL_COPY_VALUE(EX_VAR(opline->result.var), &default_value);