Remove unnecessary casts

nielsdos · nielsdos · commit 921e1785627d · 2024-12-29T18:18:38.000+01:00
diff --git a/ext/simplexml/simplexml.c b/ext/simplexml/simplexml.c
@@ -1995,7 +1995,7 @@ PHP_METHOD(SimpleXMLElement, key)
 		RETURN_THROWS();
 	}
 
-	curnode = (xmlNodePtr)((php_libxml_node_ptr *)intern->node)->node;
+	curnode = intern->node->node;
 	RETURN_STRINGL((char*)curnode->name, xmlStrlen(curnode->name));
 }
 /* }}} */
@@ -2486,7 +2486,7 @@ static void php_sxe_iterator_current_key(zend_object_iterator *iter, zval *key)
 
 	xmlNodePtr curnode = NULL;
 	if (intern != NULL && intern->node != NULL) {
-		curnode = (xmlNodePtr)((php_libxml_node_ptr *)intern->node)->node;
+		curnode = intern->node->node;
 	}
 
 	if (curnode) {

Original file line number	Diff line number	Diff line change
`@@ -1995,7 +1995,7 @@ PHP_METHOD(SimpleXMLElement, key)`
`1995`	`1995`	`RETURN_THROWS();`
`1996`	`1996`	`}`
`1997`	`1997`
`1998`		`- curnode = (xmlNodePtr)((php_libxml_node_ptr *)intern->node)->node;`
	`1998`	`+ curnode = intern->node->node;`
`1999`	`1999`	`RETURN_STRINGL((char*)curnode->name, xmlStrlen(curnode->name));`
`2000`	`2000`	`}`
`2001`	`2001`	`/* }}} */`
`@@ -2486,7 +2486,7 @@ static void php_sxe_iterator_current_key(zend_object_iterator iter, zval key)`
`2486`	`2486`
`2487`	`2487`	`xmlNodePtr curnode = NULL;`
`2488`	`2488`	`if (intern != NULL && intern->node != NULL) {`
`2489`		`- curnode = (xmlNodePtr)((php_libxml_node_ptr *)intern->node)->node;`
	`2489`	`+ curnode = intern->node->node;`
`2490`	`2490`	`}`
`2491`	`2491`
`2492`	`2492`	`if (curnode) {`