Turns out we have an API for is_neg

Girgias · Girgias · commit 90aeb416663f · 2024-05-30T13:48:01.000+01:00
diff --git a/ext/bcmath/libbcmath/src/sqrt.c b/ext/bcmath/libbcmath/src/sqrt.c
@@ -40,7 +40,7 @@ bool bc_sqrt(bc_num *num, size_t scale)
 {
 	const bc_num local_num = *num;
 	/* Initial checks. */
-	if (local_num->n_sign == MINUS) {
+	if (bc_is_neg(local_num)) {
 		/* Cannot take the square root of a negative number */
 		return false;
 	}

Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ bool bc_sqrt(bc_num *num, size_t scale)`
`40`	`40`	`{`
`41`	`41`	`const bc_num local_num = *num;`
`42`	`42`	`/* Initial checks. */`
`43`		`- if (local_num->n_sign == MINUS) {`
	`43`	`+ if (bc_is_neg(local_num)) {`
`44`	`44`	`/* Cannot take the square root of a negative number */`
`45`	`45`	`return false;`
`46`	`46`	`}`