change from review

devnexen · devnexen · commit 908d1995d97d · 2023-12-05T06:52:01.000Z
diff --git a/ext/intl/formatter/formatter_main.c b/ext/intl/formatter/formatter_main.c
@@ -65,7 +65,7 @@ static int numfmt_ctor(INTERNAL_FUNCTION_PARAMETERS, zend_error_handling *error_
 	}
 
 	if (strlen(uloc_getISO3Language(locale)) == 0) {
-		zend_argument_value_error(1, "is invalid");
+		zend_argument_value_error(1, "\"%s\" is invalid", locale);
 		return FAILURE;
 	}
     
diff --git a/ext/intl/tests/gh12727.phpt b/ext/intl/tests/gh12727.phpt
@@ -11,5 +11,5 @@ try {
     echo $e->getMessage();
 }
 ?>
---EXPECT--
-NumberFormatter::__construct(): Argument #1 ($locale) is invalid
+--EXPECTF--
+NumberFormatter::__construct(): Argument #1 ($locale) "%s" is invalid

Original file line number	Diff line number	Diff line change
`@@ -65,7 +65,7 @@ static int numfmt_ctor(INTERNAL_FUNCTION_PARAMETERS, zend_error_handling *error_`
`65`	`65`	`}`
`66`	`66`
`67`	`67`	`if (strlen(uloc_getISO3Language(locale)) == 0) {`
`68`		`- zend_argument_value_error(1, "is invalid");`
	`68`	`+ zend_argument_value_error(1, "\"%s\" is invalid", locale);`
`69`	`69`	`return FAILURE;`
`70`	`70`	`}`
`71`	`71`
Original file line number	Diff line number	Diff line change
`@@ -11,5 +11,5 @@ try {`
`11`	`11`	`echo $e->getMessage();`
`12`	`12`	`}`
`13`	`13`	`?>`
`14`		`---EXPECT--`
`15`		`-NumberFormatter::__construct(): Argument #1 ($locale) is invalid`
	`14`	`+--EXPECTF--`
	`15`	`+NumberFormatter::__construct(): Argument #1 ($locale) "%s" is invalid`