[skip-ci] More test and assertion to try to figure out wth is going on

Seems like a pointer not allocated via ZMM gets into the arena????

Author: Girgias

Zend/tests/type_declarations/relative_class_types/relative_type_in_evaled_class_using_trait.phpt

@@ -0,0 +1,27 @@
+--TEST--
+Eval Class definition should not leak memory when using compiled traits
+--FILE--
+<?php
+
+trait TraitCompiled {
+    public function bar(): self { return new self; }
+}
+
+const EVAL_CODE = <<<'CODE'
+class A {
+    use TraitCompiled;
+}
+CODE;
+
+eval(EVAL_CODE);
+
+$a1 = new A();
+$a2 = $a1->bar();
+var_dump($a2);
+
+?>
+DONE
+--EXPECT--
+object(A)#2 (0) {
+}
+DONE

Zend/tests/type_declarations/relative_class_types/relative_type_in_evaled_trait.phpt

@@ -4,28 +4,21 @@ Eval code should not leak memory when using traits
 <?php
 
 const EVAL_CODE = <<<'CODE'
-trait TraitExample {
-    public function bar(): self|C|D { return new self; }
-}
-class B {
-    use TraitExample;
+trait TraitEval {
+    public function bar(): self { return new self; }
 }
 CODE;
 
 eval(EVAL_CODE);
 
 class A {
-    use TraitExample;
+    use TraitEval;
 }
 
 $a1 = new A();
 $a2 = $a1->bar();
 var_dump($a2);
 
-//$b1 = new B();
-//$b2 = $b1->bar();
-//var_dump($b2);
-
 ?>
 DONE
 --EXPECT--

Zend/zend_opcode.c

@@ -110,6 +110,7 @@ ZEND_API void destroy_zend_function(zend_function *function)
 
 ZEND_API void zend_type_release(zend_type type, bool persistent) {
 	if (ZEND_TYPE_HAS_LIST(type)) {
+		ZEND_ASSERT((!persistent && !ZEND_TYPE_USES_ARENA(type)) && "User defined list types must be arena allocated");
 		zend_type *list_type;
 		ZEND_TYPE_LIST_FOREACH(ZEND_TYPE_LIST(type), list_type) {
 			zend_type_release(*list_type, persistent);