Skip to content

Commit 8f13599

Browse files
committed
Fix 29nb_async_connect.phpt
Intermediate states are unreliable across versions (I think), make sure we go through the whole connect procedure.
1 parent c7a86a3 commit 8f13599

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

ext/pgsql/tests/29nb_async_connect.phpt

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,18 +23,20 @@ if (!$db = pg_connect($conn_str, PGSQL_CONNECT_ASYNC)) {
2323
while (TRUE) {
2424
switch ($status = pg_connect_poll($db)) {
2525
case PGSQL_POLLING_READING:
26-
if (nb_is_readable($db_socket)) { break 2; }
26+
nb_is_readable($db_socket);
2727
break;
2828
case PGSQL_POLLING_WRITING:
29-
if (nb_is_writable($db_socket)) { break 2; }
29+
nb_is_writable($db_socket);
3030
break;
3131
case PGSQL_POLLING_FAILED:
3232
die("async connection failed");
3333
case PGSQL_POLLING_OK:
3434
break 2;
35+
default:
36+
die("unknown poll status");
3537
}
3638
}
37-
assert(pg_connection_status($db) === PGSQL_CONNECTION_MADE);
39+
assert(pg_connection_status($db) === PGSQL_CONNECTION_OK);
3840
echo "OK";
3941

4042
pg_close($db);

0 commit comments

Comments
 (0)