Do not check X-Powered-By header in FPM tester if expose_php off

bukka · bukka · commit 8e1cef43414c · 2022-09-29T15:27:33.000+01:00
Closes GH-9508
diff --git a/sapi/fpm/tests/response.inc b/sapi/fpm/tests/response.inc
@@ -102,7 +102,7 @@ class Response
     /**
      * Expect header in the response.
      *
-     * @param string $name Header name.
+     * @param string $name  Header name.
      * @param string $value Header value.
      *
      * @return Response
@@ -226,7 +226,7 @@ class Response
     {
         // check default headers
         return (
-            $this->checkHeader('X-Powered-By', '|^PHP/8|', true) &&
+            ( ! ini_get('expose_php') || $this->checkHeader('X-Powered-By', '|^PHP/8|', true)) &&
             $this->checkHeader('Content-type', '|^' . $contentType . '(;\s?charset=\w+)?|', true)
         );
     }

Original file line number	Diff line number	Diff line change
`@@ -102,7 +102,7 @@ class Response`
`102`	`102`	`/**`
`103`	`103`	`* Expect header in the response.`
`104`	`104`	`*`
`105`		`- * @param string $name Header name.`
	`105`	`+ * @param string $name Header name.`
`106`	`106`	`* @param string $value Header value.`
`107`	`107`	`*`
`108`	`108`	`* @return Response`
`@@ -226,7 +226,7 @@ class Response`
`226`	`226`	`{`
`227`	`227`	`// check default headers`
`228`	`228`	`return (`
`229`		`- $this->checkHeader('X-Powered-By', '\|^PHP/8\|', true) &&`
	`229`	`+ ( ! ini_get('expose_php') \|\| $this->checkHeader('X-Powered-By', '\|^PHP/8\|', true)) &&`
`230`	`230`	`$this->checkHeader('Content-type', '\|^' . $contentType . '(;\s?charset=\w+)?\|', true)`
`231`	`231`	`);`
`232`	`232`	`}`