Fix leak in gmp_pow()

nikic · nikic · commit 8e167a2a0017 · 2015-04-16T16:04:19.000+02:00
diff --git a/ext/gmp/gmp.c b/ext/gmp/gmp.c
@@ -1428,11 +1428,12 @@ ZEND_FUNCTION(gmp_pow)
 		RETURN_FALSE;
 	}
 
-	INIT_GMP_RETVAL(gmpnum_result);
 	if (Z_TYPE_P(base_arg) == IS_LONG && Z_LVAL_P(base_arg) >= 0) {
+		INIT_GMP_RETVAL(gmpnum_result);
 		mpz_ui_pow_ui(gmpnum_result, Z_LVAL_P(base_arg), exp);
 	} else {
 		FETCH_GMP_ZVAL(gmpnum_base, base_arg, temp_base);
+		INIT_GMP_RETVAL(gmpnum_result);
 		mpz_pow_ui(gmpnum_result, gmpnum_base, exp);
 		FREE_GMP_TEMP(temp_base);
 	}

Original file line number	Diff line number	Diff line change
`@@ -1428,11 +1428,12 @@ ZEND_FUNCTION(gmp_pow)`
`1428`	`1428`	`RETURN_FALSE;`
`1429`	`1429`	`}`
`1430`	`1430`
`1431`		`- INIT_GMP_RETVAL(gmpnum_result);`
`1432`	`1431`	`if (Z_TYPE_P(base_arg) == IS_LONG && Z_LVAL_P(base_arg) >= 0) {`
	`1432`	`+ INIT_GMP_RETVAL(gmpnum_result);`
`1433`	`1433`	`mpz_ui_pow_ui(gmpnum_result, Z_LVAL_P(base_arg), exp);`
`1434`	`1434`	`} else {`
`1435`	`1435`	`FETCH_GMP_ZVAL(gmpnum_base, base_arg, temp_base);`
	`1436`	`+ INIT_GMP_RETVAL(gmpnum_result);`
`1436`	`1437`	`mpz_pow_ui(gmpnum_result, gmpnum_base, exp);`
`1437`	`1438`	`FREE_GMP_TEMP(temp_base);`
`1438`	`1439`	`}`