Use ZVAL_COPY_VALUE for copying parser result to return_value

bukka · bukka · commit 8e102504494d · 2015-01-01T19:19:31.000Z
diff --git a/ext/json/json_parser.y b/ext/json/json_parser.y
@@ -85,7 +85,7 @@ void php_json_parser_array_append(zval *array, zval *zvalue);
 %% /* Rules */
 
 start:
-		value PHP_JSON_T_EOI    { $$ = $1; *parser->return_value = $1; PHP_JSON_USE($2); YYACCEPT; }
+		value PHP_JSON_T_EOI    { $$ = $1; ZVAL_COPY_VALUE(parser->return_value, &$1); PHP_JSON_USE($2); YYACCEPT; }
 	|	value errlex            { PHP_JSON_USE_2($$, $1, $2); }
 ;
 

Original file line number	Diff line number	Diff line change
`@@ -85,7 +85,7 @@ void php_json_parser_array_append(zval array, zval zvalue);`
`85`	`85`	`%% /* Rules */`
`86`	`86`
`87`	`87`	`start:`
`88`		`- value PHP_JSON_T_EOI { $$ = $1; *parser->return_value = $1; PHP_JSON_USE($2); YYACCEPT; }`
	`88`	`+ value PHP_JSON_T_EOI { $$ = $1; ZVAL_COPY_VALUE(parser->return_value, &$1); PHP_JSON_USE($2); YYACCEPT; }`
`89`	`89`	`\| value errlex { PHP_JSON_USE_2($$, $1, $2); }`
`90`	`90`	`;`
`91`	`91`