Fix may_throw and indirect_reference in tracing JIT

Reuse the zend_may_throw logic instead of repeating it here.

Don't set indirect_reference if container may be `false`, as this
is going through the slow path now, and the container may not
be in r0 anymore, which is what zend_jit_fetch_indirect_var()
assumes.

Author: nikic

Zend/Optimizer/zend_inference.c

@@ -4516,6 +4516,7 @@ ZEND_API int zend_may_throw_ex(const zend_op *opline, const zend_ssa_op *ssa_op,
 				case ZEND_ISSET_ISEMPTY_CV:
 				case ZEND_MAKE_REF:
 				case ZEND_FETCH_DIM_W:
+				case ZEND_FETCH_LIST_W:
 					break;
 				default:
 					/* undefined variable warning */

ext/opcache/jit/zend_jit_trace.c

@@ -5196,18 +5196,15 @@ static const void *zend_jit_trace(zend_jit_trace_rec *trace_buffer, uint32_t par
 						op1_def_info = OP1_DEF_INFO();
 						if (!zend_jit_fetch_dim(&dasm_state, opline,
 								op1_info, op1_addr, op2_info, RES_REG_ADDR(),
-								(opline->opcode == ZEND_FETCH_DIM_RW
-								 || opline->op2_type == IS_UNUSED
-								 || (op1_info & (MAY_BE_TRUE|MAY_BE_LONG|MAY_BE_DOUBLE|MAY_BE_STRING|MAY_BE_OBJECT|MAY_BE_RESOURCE|MAY_BE_REF))
-								 || (op2_info & (MAY_BE_UNDEF|MAY_BE_RESOURCE|MAY_BE_ARRAY|MAY_BE_OBJECT))
+								(zend_may_throw_ex(opline, ssa_op, op_array, ssa, op1_info, op2_info)
 								 || (opline->op1_type == IS_VAR
 								  && (op1_info & MAY_BE_UNDEF)
 								  && !ssa->var_info[ssa_op->op1_use].indirect_reference)))) {
 							goto jit_failure;
 						}
 						if (ssa_op->result_def > 0
 						 && (opline->opcode == ZEND_FETCH_DIM_W || opline->opcode == ZEND_FETCH_LIST_W)
-						 && !(op1_info & (MAY_BE_TRUE|MAY_BE_LONG|MAY_BE_DOUBLE|MAY_BE_STRING|MAY_BE_OBJECT|MAY_BE_RESOURCE|MAY_BE_REF))
+						 && !(op1_info & (MAY_BE_FALSE|MAY_BE_TRUE|MAY_BE_LONG|MAY_BE_DOUBLE|MAY_BE_STRING|MAY_BE_OBJECT|MAY_BE_RESOURCE|MAY_BE_REF))
 						 && !(op2_info & (MAY_BE_UNDEF|MAY_BE_RESOURCE|MAY_BE_ARRAY|MAY_BE_OBJECT))) {
 							ssa->var_info[ssa_op->result_def].indirect_reference = 1;
 						}