Add some assertions

Girgias · Girgias · commit 8c551f766e4a · 2022-05-11T19:59:26.000+01:00
diff --git a/sapi/cli/php_cli_server.c b/sapi/cli/php_cli_server.c
@@ -1896,7 +1896,11 @@ static void php_cli_server_client_dtor(php_cli_server_client *client) /* {{{ */
 	}
 	pefree(client->addr, 1);
 	zend_string_release_ex(client->addr_str, /* persistent */ true);
-	// TODO release client->current_header_name ?
+
+	/* Headers must be sent */
+	assert(client->current_header_name == NULL);
+	assert(client->current_header_value == NULL);
+
 	if (client->content_sender_initialized) {
 		php_cli_server_content_sender_dtor(&client->content_sender);
 	}

Original file line number	Diff line number	Diff line change
`@@ -1896,7 +1896,11 @@ static void php_cli_server_client_dtor(php_cli_server_client client) / {{{ */`
`1896`	`1896`	`}`
`1897`	`1897`	`pefree(client->addr, 1);`
`1898`	`1898`	`zend_string_release_ex(client->addr_str, /* persistent */ true);`
`1899`		`- // TODO release client->current_header_name ?`
	`1899`	`+`
	`1900`	`+ /* Headers must be sent */`
	`1901`	`+ assert(client->current_header_name == NULL);`
	`1902`	`+ assert(client->current_header_value == NULL);`
	`1903`	`+`
`1900`	`1904`	`if (client->content_sender_initialized) {`
`1901`	`1905`	`php_cli_server_content_sender_dtor(&client->content_sender);`
`1902`	`1906`	`}`