Skip to content

Commit 89eaa1f

Browse files
committed
ext/gmp: Refactor gmp_cmp() test
1 parent 601f6cd commit 89eaa1f

File tree

1 file changed

+24
-14
lines changed

1 file changed

+24
-14
lines changed

ext/gmp/tests/gmp_cmp.phpt

Lines changed: 24 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -5,17 +5,27 @@ gmp
55
--FILE--
66
<?php
77

8-
var_dump(gmp_cmp(123123,-123123));
9-
var_dump(gmp_cmp("12345678900987654321","12345678900987654321"));
10-
var_dump(gmp_cmp("12345678900987654321","123456789009876543211"));
11-
var_dump(gmp_cmp(0,0));
12-
var_dump(gmp_cmp(1231222,0));
13-
var_dump(gmp_cmp(0,345355));
8+
function cmp_helper($l, $r) {
9+
echo 'gmp(', var_export($l, true), ', ', var_export($r, true), '): ';
10+
$r = gmp_cmp($l, $r);
11+
echo match (true) {
12+
$r === 0 => "equals\n",
13+
$r < 0 => "right greater than left\n",
14+
$r > 0 => "left greater than right\n",
15+
};
16+
}
17+
18+
cmp_helper(123123,-123123);
19+
cmp_helper("12345678900987654321","12345678900987654321");
20+
cmp_helper("12345678900987654321","123456789009876543211");
21+
cmp_helper(0,0);
22+
cmp_helper(1231222,0);
23+
cmp_helper(0,345355);
1424

1525
$n = gmp_init("827278512385463739");
1626
var_dump(gmp_cmp(0,$n) < 0);
1727
$n1 = gmp_init("827278512385463739");
18-
var_dump(gmp_cmp($n1,$n));
28+
var_dump(gmp_cmp($n1,$n) === 0);
1929

2030
try {
2131
var_dump(gmp_cmp(array(),array()));
@@ -26,13 +36,13 @@ try {
2636
echo "Done\n";
2737
?>
2838
--EXPECT--
29-
int(1)
30-
int(0)
31-
int(-1)
32-
int(0)
33-
int(1)
34-
int(-1)
39+
gmp(123123, -123123): left greater than right
40+
gmp('12345678900987654321', '12345678900987654321'): equals
41+
gmp('12345678900987654321', '123456789009876543211'): right greater than left
42+
gmp(0, 0): equals
43+
gmp(1231222, 0): left greater than right
44+
gmp(0, 345355): right greater than left
45+
bool(true)
3546
bool(true)
36-
int(0)
3747
gmp_cmp(): Argument #1 ($num1) must be of type GMP|string|int, array given
3848
Done

0 commit comments

Comments
 (0)